Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a few unused imports #2888

Merged
merged 1 commit into from
Nov 27, 2018
Merged

Conversation

kinow
Copy link
Member

@kinow kinow commented Nov 26, 2018

I think the cylc.flags ones are from #2865 & #2871. The other sys imports must have crawled somewhere over the last changes.

Not removing the unused LOG, as even though they are not used, I remember disabling one somewhere some time ago, and logging/debug stopped working. I think that's by design.

@kinow kinow added the small label Nov 26, 2018
@kinow kinow added this to the soon milestone Nov 26, 2018
@kinow kinow self-assigned this Nov 26, 2018
@hjoliver
Copy link
Member

(Had a spurious T-CI fail, but passed on re-run).

Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. One review will do.

@hjoliver hjoliver modified the milestones: soon, next release Nov 27, 2018
@hjoliver hjoliver merged commit cf31515 into cylc:master Nov 27, 2018
@kinow
Copy link
Member Author

kinow commented Nov 27, 2018

Thanks for kicking Travis, and for the review.

@kinow kinow deleted the remove-unused-imports branch March 14, 2019 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants