shellcheck: lint shell script files #3068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliver-sanders
commented
Apr 3, 2019
ColemanTom
reviewed
Apr 3, 2019
oliver-sanders
force-pushed
the
shellcheck
branch
from
da600f0
to
9f3239a
Compare
matthewrmshin
approved these changes
Apr 4, 2019
|
Added a scary BLOCKED label. |
ColemanTom
reviewed
Apr 4, 2019
|
Removing the "scary BLOCKED label", the only bash4 syntax is in |
oliver-sanders
force-pushed
the
shellcheck
branch
from
9f3239a
to
2fb106f
Compare
oliver-sanders
force-pushed
the
shellcheck
branch
from
2fb106f
to
fd369ab
Compare
hjoliver
approved these changes
Apr 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run the brilliantly named
shellcheckover all shell scripts to improve code quality and cut down on review overheads.shellcheckruns over files rather than projects unlike many other linters (e.g. pycodestyle) so I've implemented a minimal script for including / excluding files in the check. I did look at borrowing the tox interface from pycodestyle but it would probably be more effort than it's worth for this simple linter.