Fix recent shellcheck-inspired quoting errors. #3092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK now we understand: the spurious quotes were added to satisfy the shellcheck "word splitting" warning, which in this case is wrong. Disabled the warning with a line-specific ignore comment. |
|
👍 will just wait for Travis-CI to finish running the build. And for the record, here's a useful link @hjoliver posted on Riot about the issue: https://github.com/koalaman/shellcheck/wiki/SC2046#exceptions |
hjoliver
changed the title
kinow
force-pushed
the
test-b-command-fix
branch
from
eabbcbb
to
a1cbab7
Compare
|
Whoops. Sorry, should have spotted that the tests were silently skipping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert a few lines of #3068
In several places: remove outer quotes that incorrectly turn a whole bunch of args into a single arg containing spaces.
@kinow - one review will do, since functional tests currently broken by the bug
@oliver-sanders can take a look afterwards to check that I've done the right thing...