-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move parsec to cylc.parsec #3132
Conversation
Also fixes some left overs of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two comments to fix the horrors introduced by me!
I noticed that the functional tests from |
- 'lib/jinja2/**' | ||
- 'lib/markupsafe/**' | ||
- 'lib/parsec/tests/**' | ||
- 'licences/**' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was initially for parsec, but then I realized we were missing a few more lines from other folders removed recently. That's why there are multiple lines here 👍
Interesting. Promoting a draft pull request to ready-to-review does not trigger Travis. So there's only one check here. I waited until Travis builds passed for my fork though: https://travis-ci.org/kinow/cylc-flow/builds/526686529 So it should be OK, hopefully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment on Python 2.6 back compat logic. Otherwise good to go.
Sorry, but we should still add the |
Oh, that line had to stay? No problemo. Done in cc6ed7d |
Will merge when CI is done. |
Close #2880
Simply moves the old
parsec
module now tocylc.parsec
. This will reduce the number of modules exported after the user installs cylc via pip/conda/etc.This reduces too the risk of package collision, as there is another
parsec
package already in PYPI that could be using theparsec
namespace already.pytest
andcylc run five
passed locally. Making it a draft until functional tests have passed as well.Cheers
Bruno