Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move parsec to cylc.parsec #3132

Merged
merged 4 commits into from
May 1, 2019
Merged

Move parsec to cylc.parsec #3132

merged 4 commits into from
May 1, 2019

Conversation

kinow
Copy link
Member

@kinow kinow commented Apr 26, 2019

Close #2880

Simply moves the old parsec module now to cylc.parsec. This will reduce the number of modules exported after the user installs cylc via pip/conda/etc.

This reduces too the risk of package collision, as there is another parsec package already in PYPI that could be using the parsec namespace already.

pytest and cylc run five passed locally. Making it a draft until functional tests have passed as well.

Cheers
Bruno

@kinow kinow self-assigned this Apr 26, 2019
@kinow kinow added this to the cylc-8.0a1 milestone Apr 26, 2019
@kinow
Copy link
Member Author

kinow commented Apr 26, 2019

Also fixes some left overs of setup.py, like remove some exclusions from Codacy configuration file.

Copy link
Contributor

@matthewrmshin matthewrmshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments to fix the horrors introduced by me!

lib/cylc/__init__.py Outdated Show resolved Hide resolved
lib/cylc/cfgvalidate.py Outdated Show resolved Hide resolved
@kinow
Copy link
Member Author

kinow commented May 1, 2019

I noticed that the functional tests from parsec were in the wrong folder. Correcting it, they were not passing once put under the /tests/ folder. Something with the Python code that is loaded there... so I modified the Python code a bit (just eliminated the need for lib/python/config.py by moving all the code to bin/synonym.py), and now it should - hopefully 🤞 - pass in Travis.

- 'lib/jinja2/**'
- 'lib/markupsafe/**'
- 'lib/parsec/tests/**'
- 'licences/**'
Copy link
Member Author

@kinow kinow May 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was initially for parsec, but then I realized we were missing a few more lines from other folders removed recently. That's why there are multiple lines here 👍

@kinow kinow marked this pull request as ready for review May 1, 2019 01:04
@kinow
Copy link
Member Author

kinow commented May 1, 2019

Interesting. Promoting a draft pull request to ready-to-review does not trigger Travis. So there's only one check here.

I waited until Travis builds passed for my fork though: https://travis-ci.org/kinow/cylc-flow/builds/526686529

So it should be OK, hopefully.

@kinow kinow closed this May 1, 2019
@kinow kinow reopened this May 1, 2019
@kinow
Copy link
Member Author

kinow commented May 1, 2019

A-ha! The old close pull request, open pull request trick. Travis build triggered!

Agent86

Copy link
Contributor

@matthewrmshin matthewrmshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on Python 2.6 back compat logic. Otherwise good to go.

lib/cylc/__init__.py Outdated Show resolved Hide resolved
@cylc cylc deleted a comment May 1, 2019
@matthewrmshin
Copy link
Contributor

Sorry, but we should still add the LOG.addHandler(logging.NullHandler()) statement, just without the need for the if ... test.

@kinow
Copy link
Member Author

kinow commented May 1, 2019

Oh, that line had to stay? No problemo. Done in cc6ed7d

@cylc cylc deleted a comment May 1, 2019
@matthewrmshin
Copy link
Contributor

Will merge when CI is done.

@matthewrmshin matthewrmshin merged commit 321a596 into cylc:master May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move parsec to cylc package
3 participants