Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cylc-flow rename in README badges, setup.py, and a few more places #3140

Merged
merged 2 commits into from
May 1, 2019

Conversation

kinow
Copy link
Member

@kinow kinow commented May 1, 2019

While working on #3132 I was waiting for Codecov to update the coverage, then noticed that the travis badge was set to unknown, and I was expecting Codecov to appear as 89%, but clicking on the badge it took me to the wrong place there.

Turns out we forgot to update the badge links. Also fixed the links in setup.py. This is the first commit in this change.

Then searched for cylc/cylc-[^-flow] on PyCharm and replaced by cylc/cylc-flow. Happy to revert this second commit if considered unnecessary 👍

@kinow kinow self-assigned this May 1, 2019
@kinow kinow added the doc Documentation label May 1, 2019
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same on 7.8.x? (sorry!)

@hjoliver
Copy link
Member

hjoliver commented May 1, 2019

(For the links, not the badges).

@kinow
Copy link
Member Author

kinow commented May 1, 2019

Oh, true, we can backport the links. Easy-peasy. Just started work on the xtriggers... will see how far I can go until either I can't make progress, or Travis is busy building it, then will prepare a 7.8.x small pull request (probably doesn't deserve a CHANGES.md)

@matthewrmshin matthewrmshin added this to the cylc-8.0a1 milestone May 1, 2019
@matthewrmshin matthewrmshin merged commit 789d502 into cylc:master May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants