-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conf tree #3559
Conf tree #3559
Conversation
An early example of what the built documentation will look like (using the default Sphinx theme) And more: With the Read The Docs theme it will look more like the rose API. http://metomi.github.io/rose/doc/html/api/configuration/application.html#rose:file:rose-app.conf |
Is this example based on the code in this branch? If so, how? |
4b2eacf
to
fac95f2
Compare
9fbd829
to
8eaec74
Compare
f5a4f50
to
8e7a2c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An early example of what the built documentation will look like (using the default Sphinx theme)
Is this example based on the code in this branch? If so, how?
Once built, this snippet can be found in Docs » Reference » Configuration » Suite Configuration
''') | ||
Conf('max active cycle points', VDR.V_INTEGER, 3, desc=''' | ||
Runahead limiting prevents the fastest tasks in a suite from | ||
getting too far ahead of the slowest ones, as documented in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run ahead limit already documented a couple of lines up (line 252)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Configs gets alphabetically sorted before rendering the output in Sphinx so these two won't appear next to each other in the final docs.
directory paths involving the registration name in ``$PATH`` | ||
variables). They may not contain the "." character (it will be | ||
interpreted as the namespace hierarchy delimiter, separating | ||
groups and names -huh?). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-huh? ...is that supposed to be there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not! Unless it was special emphasis.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have now built the docs, looks great. Minor suggestions across the 3 prs.
Co-authored-by: Melanie Hall <37735232+datamel@users.noreply.github.com>
Thanks for putting up the typos as suggestions, made things much easier :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with the cylc-doc PR.
These changes close #3253
Sibling PRs:
Highlights:
Other Stuff:
Todo:
__MANY__
items.Future work:
options
list to a dictionary.PT1H
example in every config which takes a duration as an arugment.self.config(SPEC['scheduling']['initial cycle point']
):cylc:conf'[a][b]c'
syntax.Context Node Fun:
Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.