7.8.x: auto-restart: only wait for local jobs running on localhost #3814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliver-sanders
force-pushed
the
7.8.6.auto-restart-local-jobs
branch
from
8836f83
to
b6698f9
Compare
oliver-sanders
force-pushed
the
7.8.6.auto-restart-local-jobs
branch
from
b6698f9
to
ba1dbb8
Compare
7 tasks
oliver-sanders
changed the title
hjoliver
approved these changes
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small bug in the auto-restart logic which has gone unnoticed since its creation.
Before attempting auto-restart Cylc is supposed to wait for all locally running jobs (i.e. those submitted via background or at) on the suite host to finish.
Unfortunately this functionality is somewhat overzealous and is waiting for all jobs submitted via background or at on any host to complete before restarting.
Some users have exceptionally long-running background jobs (pollers) which have highlighted this bug.
Requirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.