Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-restart: only wait for local jobs running on localhost #3815

Merged
merged 1 commit into from
Sep 15, 2020

Conversation

oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Sep 14, 2020

Cylc8 port of #3814.

Before attempting auto-restart Cylc is supposed to wait for all locally running jobs
(i.e. those submitted via background or at) on the suite host to finish.

Unfortunately this functionality is somewhat overzealous and is waiting for all jobs
submitted via background or at on any host to complete before restarting.

Some users have exceptionally long-running background jobs (pollers) which
have highlighted this bug.

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Already covered by existing tests.
  • Appropriate change log entry included.
  • No documentation update required.
  • No dependency changes.

@oliver-sanders oliver-sanders added the bug Something is wrong :( label Sep 14, 2020
@oliver-sanders oliver-sanders added this to the cylc-8.0a3 milestone Sep 14, 2020
@oliver-sanders oliver-sanders self-assigned this Sep 14, 2020
Copy link
Contributor

@datamel datamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@hjoliver hjoliver merged commit ec01d2d into cylc:master Sep 15, 2020
@oliver-sanders oliver-sanders deleted the auto-restart-local branch September 15, 2020 11:36
@hjoliver hjoliver modified the milestones: cylc-8.0a3, cylc-8.0b0 Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants