Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "disable automatic shutdown" #3942

Merged
merged 4 commits into from
Nov 12, 2020
Merged

Conversation

MetRonnie
Copy link
Member

These changes partially address #3696

From the config proposal: [cylc]disable automatic shutdown -> obsolete

hjoliver on 9 Oct 2019
I think we can get rid of this item. The original intent was to make suites stay alive for ever, even if finished, so that users could see them in the GUI until explicitly shutting them down. But that is really not necessary, and may lead to forgotten zombie suites.

Requirements check-list

@MetRonnie MetRonnie added the config change Involves a change to global or workflow config label Nov 12, 2020
@MetRonnie MetRonnie added this to the cylc-8.0.0 milestone Nov 12, 2020
@MetRonnie MetRonnie self-assigned this Nov 12, 2020
sleep 5
cylc stop --max-polls=10 --interval=2 "${SUITE_NAME}" 1>'/dev/null' 2>&1
run_fail "${TEST_NAME_BASE}-stall" \
run_fail "${TEST_NAME_BASE}-not-stalled" \
grep -q -F 'WARNING - suite stalled' "${SUITE_RUN_DIR}/log/suite/log"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell this will still perform the objective of the test: "Test no stall when task pool has succeeded tasks only."

Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but tests/f/events/31... can be removed; it doesn't really do anything useful now because the scheduler will just shut down as soon as the lone tasks succeeds (and in SoD there are no succeeded tasks kept in the task pool anyway).

@hjoliver
Copy link
Member

Meh, to save time I've pushed the test deletion to your branch. One review will do. All the other tests already passed.

@hjoliver
Copy link
Member

(Also fixed a conflict in a deprecations test, passed in my environment).

@hjoliver hjoliver merged commit bc8c48c into cylc:master Nov 12, 2020
@MetRonnie MetRonnie deleted the config-changes-3 branch November 12, 2020 21:15
@MetRonnie
Copy link
Member Author

MetRonnie commented Nov 12, 2020

@hjoliver As you seem to be on a config changes roll, you can review #3943 too if you like 😋

@MetRonnie MetRonnie modified the milestones: cylc-8.0.0, cylc-8.0a3 Nov 13, 2020
@hjoliver hjoliver modified the milestones: cylc-8.0a3, cylc-8.0b0 Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config change Involves a change to global or workflow config
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants