-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "disable automatic shutdown" #3942
Conversation
sleep 5 | ||
cylc stop --max-polls=10 --interval=2 "${SUITE_NAME}" 1>'/dev/null' 2>&1 | ||
run_fail "${TEST_NAME_BASE}-stall" \ | ||
run_fail "${TEST_NAME_BASE}-not-stalled" \ | ||
grep -q -F 'WARNING - suite stalled' "${SUITE_RUN_DIR}/log/suite/log" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can tell this will still perform the objective of the test: "Test no stall when task pool has succeeded tasks only."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but tests/f/events/31...
can be removed; it doesn't really do anything useful now because the scheduler will just shut down as soon as the lone tasks succeeds (and in SoD there are no succeeded tasks kept in the task pool anyway).
Meh, to save time I've pushed the test deletion to your branch. One review will do. All the other tests already passed. |
b2c8005
to
d2a72ca
Compare
(Also fixed a conflict in a deprecations test, passed in my environment). |
These changes partially address #3696
From the config proposal:
[cylc]disable automatic shutdown
-> obsoleteRequirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.