Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global config changes: process pool, logging #3943

Merged
merged 4 commits into from
Nov 16, 2020

Conversation

MetRonnie
Copy link
Member

@MetRonnie MetRonnie commented Nov 12, 2020

These changes partially address #3696

  • process pool * -> [scheduler]process pool *
  • [suite logging] -> [scheduler][logging]
  • run directory rolling archive length -> [scheduler]run directory rolling archive length (Update: this setting was later removed - Remove run dir housekeeping #4162)

Also the test_header function create_test_global_config has been simplified to only arg which is appended to the user's global config, as there are no longer any top-level global config items that would need to be prepended.

Requirements check-list

@MetRonnie MetRonnie added the config change Involves a change to global or workflow config label Nov 12, 2020
@MetRonnie MetRonnie added this to the cylc-8.0.0 milestone Nov 12, 2020
@MetRonnie MetRonnie self-assigned this Nov 12, 2020
@MetRonnie MetRonnie requested review from wxtim and removed request for datamel November 12, 2020 21:14
@MetRonnie MetRonnie changed the title Config changes 4 Global config changes: process pool, logging Nov 12, 2020
As global config no longer contains top-level settings
@MetRonnie MetRonnie marked this pull request as ready for review November 13, 2020 10:58
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MetRonnie MetRonnie removed the request for review from oliver-sanders November 13, 2020 12:20
@wxtim wxtim merged commit a587865 into cylc:master Nov 16, 2020
@MetRonnie MetRonnie deleted the config-changes-4 branch November 16, 2020 10:38
@MetRonnie MetRonnie modified the milestones: cylc-8.0.0, cylc-8.0a3 Nov 16, 2020
@hjoliver hjoliver modified the milestones: cylc-8.0a3, cylc-8.0b0 Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config change Involves a change to global or workflow config
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants