Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant _dump_item method #3960

Merged
merged 1 commit into from
Nov 29, 2020
Merged

Remove redundant _dump_item method #3960

merged 1 commit into from
Nov 29, 2020

Conversation

datamel
Copy link
Contributor

@datamel datamel commented Nov 23, 2020

This code should probably have been removed in the pr which removed get_auth_items (#3509)

This is a very small change with no associated Issue.

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Does not need tests (only removing unused code).
  • No change log entry required (why? invisible to users).
  • No documentation update required.
  • No dependency changes.

@datamel datamel self-assigned this Nov 23, 2020
hjoliver
hjoliver approved these changes Nov 29, 2020
View reviewed changes
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 one review will do

@hjoliver hjoliver merged commit 80bb050 into cylc:master Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjoliver hjoliver hjoliver approved these changes

Assignees

@datamel datamel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@datamel @hjoliver