Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant _dump_item method #3960

Merged
merged 1 commit into from
Nov 29, 2020
Merged

Remove redundant _dump_item method #3960

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 0 additions & 22 deletions cylc/flow/suite_files.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,28 +598,6 @@ def create_server_keys(keys, suite_srv_dir):
os.umask(old_umask)


def _dump_item(path, item, value):
"""Dump "value" to a file called "item" in the directory "path".

1. File permission should already be user-read-write-only on
creation by mkstemp.
2. The combination of os.fsync and os.rename should guarantee
that we don't end up with an incomplete file.
"""
os.makedirs(path, exist_ok=True)
from tempfile import NamedTemporaryFile
handle = NamedTemporaryFile(prefix=item, dir=path, delete=False)
try:
handle.write(value.encode())
except AttributeError:
handle.write(value)
os.fsync(handle.fileno())
handle.close()
fname = os.path.join(path, item)
os.rename(handle.name, fname)
LOG.debug('Generated %s', fname)


def get_suite_title(reg):
"""Return the the suite title without a full file parse

Expand Down