actions: fudge /etc/hosts #4176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've just noticed the bash test workflow has no timeout, so it might be worth adding while you're at it diff --git a/.github/workflows/bash.yml b/.github/workflows/bash.yml
index 3ebfc086c..ebd791ed2 100644
--- a/.github/workflows/bash.yml
+++ b/.github/workflows/bash.yml
@@ -10,6 +10,7 @@ on:
jobs:
bash-docker:
runs-on: ubuntu-latest
+ timeout-minutes: 15
strategy:
matrix:
bash-version: |
* ask the host for its names then use those to configure /etc/hosts * nasty hack to deal with broken DNS on GH actions * actions/runner-images#3185
* skip tcp comms if comms method == poll * convert comms method to enum
oliver-sanders
force-pushed
the
mod-etc-hosts
branch
from
f6916c2
to
7f895de
Compare
* wait for long enough for the started message to get picked up by the scheduler * this test was passing before because it wasn't testing polling properly (because poll task comms was attempting TCP comms anyway)
* test was not suitible for use with polling task comms
hjoliver
reviewed
Apr 20, 2021
|
|
||
| comms_method = get_comms_method() | ||
| return get_runtime_client(comms_method, workflow, timeout=timeout) | ||
| return get_runtime_client(get_comms_method(), workflow, timeout=timeout) |
There was a problem hiding this comment.
This seems like a function that doesn't need to exist! Merge with the previous one?
hjoliver
approved these changes
Apr 20, 2021
There was a problem hiding this comment.
Looks good, tests all passing. It seems actions/runner-images#3185 has been acknowledged as a bug, so we shouldn't need the fudge for long.
🍾 |
oliver-sanders
requested review from
MetRonnie and
datamel
and removed request for
MetRonnie
|
@datamel could you make sure you are happy with the comms code changes. (I removed the |
datamel
approved these changes
Apr 20, 2021
Co-authored-by: Melanie Hall <37735232+datamel@users.noreply.github.com>
oliver-sanders
force-pushed
the
mod-etc-hosts
branch
from
2c66506
to
e81a1fe
Compare
datamel
approved these changes
Apr 20, 2021
|
Going in with two approvals before any more unrelated bugs show up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cylc messageso that it doesn't attempt to send TCP messages whencommunication method = poll.comms:poll.Requirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.