-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fixes #4180
Bug fixes #4180
Conversation
The bug was reproducable like so: - Have a workflow in a source dir with suite.rc instead of flow.cylc - Run cylc validate on the source (this creates a flow.cylc symlink) - Run cylc install - The flow.cylc symlink would get copied over, still pointing at the source dir suite.rc instead of the run dir suite.rc
Fast test failures seem to be due to pytest-dev/pytest-asyncio#209, passing locally for me on pytest-asyncio 0.14.0 |
Passing locally for me on pytest-asyncio 0.15.0 but failing on GH actions?! I've pinned us back to 0.14.0 on #4176 until a fix is out If you can get failures on 0.14.0 could you try out their candidate fix (on pytest-asyncio:master). |
This comment has been minimized.
This comment has been minimized.
(Cancelled Actions after merging a trivial CHANGES.md conflict) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good 👍
This is a small change with no associated Issue.
Fix bug where installing a
suite.rc
workflow that had beencylc validate
d in its source dir would result in aflow.cylc
symlink being copied over still pointing to the source dirsuite.rc
instead of the one in the run dirFix bug where the deprecated
flow.cylc
config item(skipped
[[[<recurrence>]]]
section) did not log a warning when upgraded toDo not show traceback when any
CylcError
gets raised during running of the workflow, only show traceback for generic uncaught exceptions (unless using--debug
, in which case show traceback for all exceptions)Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.