Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes #4180

Merged
merged 12 commits into from
Apr 23, 2021
Merged

Bug fixes #4180

merged 12 commits into from
Apr 23, 2021

Conversation

MetRonnie
Copy link
Member

@MetRonnie MetRonnie commented Apr 20, 2021

This is a small change with no associated Issue.

  • Fix bug where installing a suite.rc workflow that had been cylc validated in its source dir would result in a flow.cylc symlink being copied over still pointing to the source dir suite.rc instead of the one in the run dir

  • Fix bug where the deprecated flow.cylc config item

    [scheduling]
        [[dependencies]]
            graph = foo

    (skipped [[[<recurrence>]]] section) did not log a warning when upgraded to

    [scheduling]
        [[graph]]
            graph = foo  # (same as R1 = foo)
  • Do not show traceback when any CylcError gets raised during running of the workflow, only show traceback for generic uncaught exceptions (unless using --debug, in which case show traceback for all exceptions)

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Appropriate tests are included (unit and/or functional).
  • Appropriate change log entry included.
  • No documentation update required.
  • No dependency changes.

The bug was reproducable like so:
- Have a workflow in a source dir with suite.rc instead of flow.cylc
- Run cylc validate on the source (this creates a flow.cylc symlink)
- Run cylc install
- The flow.cylc symlink would get copied over, still pointing at the 
source dir suite.rc instead of the run dir suite.rc
@MetRonnie MetRonnie added the bug Something is wrong :( label Apr 20, 2021
@MetRonnie MetRonnie added this to the cylc-8.0b2 milestone Apr 20, 2021
@MetRonnie MetRonnie self-assigned this Apr 20, 2021
@MetRonnie
Copy link
Member Author

MetRonnie commented Apr 20, 2021

Fast test failures seem to be due to pytest-dev/pytest-asyncio#209, passing locally for me on pytest-asyncio 0.14.0

@oliver-sanders
Copy link
Member

oliver-sanders commented Apr 20, 2021

passing locally for me on pytest-asyncio 0.14.0

Passing locally for me on pytest-asyncio 0.15.0 but failing on GH actions?!

I've pinned us back to 0.14.0 on #4176 until a fix is out

If you can get failures on 0.14.0 could you try out their candidate fix (on pytest-asyncio:master).

@MetRonnie

This comment has been minimized.

@hjoliver
Copy link
Member

(Cancelled Actions after merging a trivial CHANGES.md conflict)

Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good 👍

@hjoliver hjoliver merged commit d90c613 into cylc:master Apr 23, 2021
@MetRonnie MetRonnie deleted the dev branch April 23, 2021 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants