-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove runN if symlink target is gone #4362
Conversation
* 'main' of github.com:wxtim/cylc: Update CHANGES.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One test still failing @wxtim
=========================== short test summary info ============================
FAILED tests/unit/test_workflow_files.py::test_delete_runN[expect1-dirs1] - A...
====== 1 failed, 963 passed, 1 skipped, 1 xfailed, 12 warnings in 36.87s =======
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fast tests failing GH Actions. Looks to me like the same ones failing on #4361 which was merged into master.
These all pass locally for me. The plus is that bash / bash-docker (5.0)
now passing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess there should also be a test that runN
is not removed if cleaning a non-latest run dir
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested manually, all good 👍
These changes close #4323
CONTRIBUTING.md
and added my name as a Code Contributor.