Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cylc 728 (with linter) #4900

Merged
merged 59 commits into from
Jul 27, 2022
Merged

Cylc 728 (with linter) #4900

Changes from 1 commit
Commits
Show all changes
59 commits
Select commit Hold shift + click to select a range
b8377ad
cylc linter
wxtim Jul 4, 2022
e0df94e
fixed: non indents on jinja2 OK
wxtim Jul 4, 2022
ae550e4
stuff
wxtim Jul 4, 2022
947cd72
add documentation for API for pre and post install plugins.
wxtim Jul 5, 2022
1d023ad
Update CHANGES.md
wxtim Jul 5, 2022
b147c42
Merge branch 'master' into cylc-linter
wxtim Jul 5, 2022
9a35f32
Merge branch 'master' into cylc-linter
wxtim Jul 5, 2022
6358a21
remove file added by mistake
wxtim Jul 5, 2022
7407bf6
undo mistaken reversions
wxtim Jul 5, 2022
719404b
re-instated --reference mode; made doc not RST
wxtim Jul 5, 2022
94621aa
added automated scraping of parsec upgraders
wxtim Jul 5, 2022
d79bc6d
wip - scraping obseletions
wxtim Jul 7, 2022
4631e80
stuff
wxtim Jul 10, 2022
34ae482
re-written linter to use Cylc workflow config
wxtim Jul 10, 2022
c79370f
updated tests to reflect all changes
wxtim Jul 10, 2022
50243d5
fix functional test
wxtim Jul 11, 2022
079892b
add test for config upgrader script
wxtim Jul 11, 2022
5cdcb76
flake8
wxtim Jul 11, 2022
ce88cc0
Update cylc/flow/scripts/lint.py
wxtim Jul 18, 2022
0ea6523
fix some issues
wxtim Jul 18, 2022
c223549
Merge branch 'cylc-linter' of github.com:wxtim/cylc into cylc-linter
wxtim Jul 18, 2022
ca6db34
Apply suggestions from code review
wxtim Jul 18, 2022
578094d
uncommented a test
wxtim Jul 18, 2022
4f79272
put all sections in []
wxtim Jul 18, 2022
b294624
added testing for prettify config function
wxtim Jul 18, 2022
fc2ee9f
fix bug @ronnie had
wxtim Jul 19, 2022
d36ca92
Added manual upgrade checks for items with complex upgraders.
wxtim Jul 19, 2022
c0df60c
Update cylc/flow/scripts/lint.py
wxtim Jul 21, 2022
4a19b09
Update cylc/flow/scripts/lint.py
wxtim Jul 21, 2022
bacada2
Update cylc/flow/scripts/lint.py
wxtim Jul 21, 2022
85f83c5
Update cylc/flow/scripts/lint.py
wxtim Jul 21, 2022
1226f56
Update cylc/flow/scripts/lint.py
wxtim Jul 21, 2022
134d752
Update cylc/flow/scripts/lint.py
wxtim Jul 21, 2022
d0f13df
Update cylc/flow/scripts/lint.py
wxtim Jul 21, 2022
165f6e2
Merge branch 'master' into cylc-linter
wxtim Jul 21, 2022
350a287
Make the linter default behaviour be linting
wxtim Jul 21, 2022
01e39aa
fix regex
wxtim Jul 21, 2022
d440b61
fix flake8 bug which crept into master
wxtim Jul 21, 2022
5b9b381
updated functional test
wxtim Jul 21, 2022
ebb8d6c
fixed broken line
wxtim Jul 21, 2022
cbb459b
merge
wxtim Jul 21, 2022
8562293
Merge branch 'master' into cylc-linter
wxtim Jul 22, 2022
a3964f0
cylc lint: review feedback
oliver-sanders Jul 25, 2022
b1596b1
Merge pull request #44 from oliver-sanders/cylc-lint
wxtim Jul 25, 2022
8b8a9e8
Apply suggestions from code review
wxtim Jul 26, 2022
44cc3e6
Merge branch 'master' into cylc-linter
wxtim Jul 26, 2022
9ee971d
fix bug
wxtim Jul 26, 2022
ffa7138
fix problems @osanders found on review
wxtim Jul 26, 2022
31d6799
fix unit tests
wxtim Jul 26, 2022
bef898d
fixed functional tests
wxtim Jul 26, 2022
3692ca7
SPAG
wxtim Jul 27, 2022
f403bcf
made __doc__ rst to make autodoc work nicely.
wxtim Jul 27, 2022
f9a2c56
fix test
wxtim Jul 27, 2022
fea7250
Apply suggestions from code review
wxtim Jul 27, 2022
7722995
Apply suggestions from code review
wxtim Jul 27, 2022
ff83770
fixed review bug -
wxtim Jul 27, 2022
8229168
fix
wxtim Jul 27, 2022
f079b35
Update cylc/flow/scripts/lint.py
wxtim Jul 27, 2022
1005f08
nice plural
wxtim Jul 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cylc/flow/scripts/lint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,14 +493,14 @@ def main(parser: COP, options: 'Values', *targets) -> None:
msg = (
f'\n{Fore.YELLOW}'
f'Checked {target} against {check_names} checks'
wxtim marked this conversation as resolved.
Show resolved Hide resolved
f'rules and found {count} issue'
f'rules and found {count} issue(s).'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"checksrules"

Checked {target} against {check_names} checksrules and found {count} issue(s).

f'{"s" if count > 1 else ""}.'
wxtim marked this conversation as resolved.
Show resolved Hide resolved
)
else:
msg = (
f'{Fore.GREEN}'
f'Checked {target} against {check_names} checks'
'Found no issues.'
f'Checked {target} against {check_names} checks and '
wxtim marked this conversation as resolved.
Show resolved Hide resolved
'found no issues.'
)

print(msg)
Expand Down