-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wait for preparing tasks to submit before auto restart #5062
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
- Tested by breaking the job-submission pipeline after the "prep" stage to ensure auto-restart is delayed by preparing jobs.
- Ran the functional/flakyfunctional restart tests locally (not run by CI).
(could do with a changelog entry for this one) |
log = LOG.debug | ||
if self.options.reftest or self.options.genref: | ||
log = LOG.info |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
log = LOG.debug | |
if self.options.reftest or self.options.genref: | |
log = LOG.info | |
log = LOG.info if (self.options.reftest or self.options.genref) else LOG.debug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't fit on 1 line which is why I left it the way it is
* master: tui: add poll mutation (cylc#5075) bump dev version Add workflow field to ClientError, ClientTimeout Bump dev version Lint.hardcode style index numbers (cylc#5055) Wait for preparing tasks to submit before auto restart (cylc#5062) update changelog Prepare release 8.0.1 scan: ignore FileNotFoundError (cylc#5065)
Fix bug where any preparing local jobs would get orphaned during the shutdown before an auto restart.
You could reproduce this bug by changing
and running the test, eventually it would orphan a preparing job and cause the test to fail.
Check List
CONTRIBUTING.md
and added my name as a Code Contributor.CHANGES.md
entry included if this is a change that can affect users