scan: ignore FileNotFoundError #5065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* During a scan directories are listed asynchronously and recursively. * If a directory is queued for listing, but then deleted before the listing takes place a FileNotFoundError will occur. * This is highly unlikely IRL, however, in the integration tests, where run dirs are created and destroyed at scale and in parallel this is actually quite likely.
MetRonnie
approved these changes
Aug 15, 2022
wxtim
approved these changes
Aug 16, 2022
8 tasks
hjoliver
pushed a commit
to hjoliver/cylc-flow
that referenced
this pull request
Aug 18, 2022
* During a scan directories are listed asynchronously and recursively. * If a directory is queued for listing, but then deleted before the listing takes place a FileNotFoundError will occur. * This is highly unlikely IRL, however, in the integration tests, where run dirs are created and destroyed at scale and in parallel this is actually quite likely.
wxtim
added a commit
to wxtim/cylc
that referenced
this pull request
Aug 18, 2022
* master: tui: add poll mutation (cylc#5075) bump dev version Add workflow field to ClientError, ClientTimeout Bump dev version Lint.hardcode style index numbers (cylc#5055) Wait for preparing tasks to submit before auto restart (cylc#5062) update changelog Prepare release 8.0.1 scan: ignore FileNotFoundError (cylc#5065)
8 tasks
wxtim
pushed a commit
to wxtim/cylc
that referenced
this pull request
Aug 26, 2022
* During a scan directories are listed asynchronously and recursively. * If a directory is queued for listing, but then deleted before the listing takes place a FileNotFoundError will occur. * This is highly unlikely IRL, however, in the integration tests, where run dirs are created and destroyed at scale and in parallel this is actually quite likely.
wxtim
pushed a commit
to wxtim/cylc
that referenced
this pull request
Oct 3, 2022
* During a scan directories are listed asynchronously and recursively. * If a directory is queued for listing, but then deleted before the listing takes place a FileNotFoundError will occur. * This is highly unlikely IRL, however, in the integration tests, where run dirs are created and destroyed at scale and in parallel this is actually quite likely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
listing takes place a FileNotFoundError will occur.
dirs are created and destroyed at scale and in parallel this is
actually quite likely.
Example fail: https://github.com/cylc/cylc-flow/runs/7805964418?check_suite_focus=true
Likely caused by #5028, not sure why, perhaps it didn't raise the error, perhaps it was more eager with its scheduling.
Tested with 110X parallelism (
pytest -n 110 tests/integration), couldn't reproduce post-fix.Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfgandconda-environment.yml.CHANGES.mdentry included if this is a change that can affect users