cylc play: add suggestion for --upgrade in non-interactive terminal
#5535
Conversation
Co-authored-by: Oliver Sanders <oliver.sanders@metoffice.gov.uk>
| @@ -523,6 +523,7 @@ def _version_check( | |||
| process=str.lower, | |||
| ) | |||
| # we are in non-interactive mode, abort abort abort | |||
| print('Use "--upgrade" to upgrade the workflow.', file=sys.stderr) | |||
There was a problem hiding this comment.
There is a bit of a mismatch printing this to stderr when just above
This workflow was previously run with <yellow>{last_run_version}</yellow>.
This version of Cylc is <green>{__version__}</green>.
was printed to stdout.
Would there be anything wrong with printing that earlier message to stderr also? Would solve this problem #5381 (comment)
There was a problem hiding this comment.
@oliver-sanders - Any reason not to print the earlier msg to stderr?
There was a problem hiding this comment.
There is a bit of a mismatch printing this to stderr when just above
Eh, not really, those messages are informational, this message conveys an actual error.
There was a problem hiding this comment.
Unfortunately the GUI and TUI are only regurgitating stderr. We should find a way for them to include the useful info about which versions are flying about IMHO
There was a problem hiding this comment.
Fair point, but a widespread issue not related to this PR.
I don't think stdout/err are a great interface for Tui/GUI, but short of a Python API (that allows Cylc version changing) I can't think of a better option that isn't tons of work.
In this case, the version compat issue should also be handled better in at the UI end as we intend to implement upgrade logic there.
MetRonnie
changed the title
cylc play: add suggestion for --upgrade in non-interactive terminal
…github.com:wxtim/cylc into fix.sort_lint_listing--correct_number_for_line_len * 'fix.sort_lint_listing--correct_number_for_line_len' of github.com:wxtim/cylc: `cylc play`: add suggestion for `--upgrade` in non-interactive terminal (cylc#5535) centralize number used for line length check. Respond to review Fix cylc lint commented-out Jinja2 bug Logging: say command actioned instead of succeeded cylc lint non zero code from warnings (cylc#5546) Fix S011 lint (cylc#5536)
Companion to cylc/cylc-uiserver#455
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).Tests are included (or explain why tests are not needed).One line message for Cylc GUI to pick up.CHANGES.mdentry included if this is a change that can affect usersCylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.N/A?.?.xbranch.