Handle trying to play workflows which require upgrade #455

wxtim · 2023-05-12T09:01:45Z

Sibling: cylc/cylc-flow#5535

Closes #429

Intercept error message about versions and upgrading and post
it to a more helpful error message than stardard "This Cylc Play command failed"
Add a toggle for the --upgrade option of Cylc Play

Check List

I have read CONTRIBUTING.md and added my name as a Code Contributor.
Contains logically grouped changes (else tidy your branch by rebase).
Does not contain off-topic changes (use other PRs for other changes).
Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
Tests are included - manually tested, thoughts on automated testing welcomed.
CHANGES.md entry included if this is a change that can affect users
~~Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.~~ N/A
If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

Manual Testing

Run a workflow with Cylc 8.1, then stop it.
Change to Cylc 8.2
Load up the GUI (if you haven't already)
Play workflow using the main button - watch for failure
Play workflow using the burger bar, edit (pencil) and toggle upgrade (it's near the bottom). watch for success.

codecov-commenter · 2023-05-12T09:05:29Z

Codecov Report

Patch coverage: 33.33% and project coverage change: -0.47% ⚠️

Comparison is base (2b866af) 77.24% compared to head (25a2924) 76.77%.
Report is 2 commits behind head on 1.3.x.

Additional details and impacted files

@@            Coverage Diff             @@
##            1.3.x     #455      +/-   ##
==========================================
- Coverage   77.24%   76.77%   -0.47%     
==========================================
  Files          12       12              
  Lines        1415     1408       -7     
  Branches      239      233       -6     
==========================================
- Hits         1093     1081      -12     
- Misses        276      279       +3     
- Partials       46       48       +2

Files Changed	Coverage Δ
cylc/uiserver/resolvers.py	`55.31% <0.00%> (-0.24%)`	⬇️
cylc/uiserver/schema.py	`71.01% <100.00%> (+0.21%)`	⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CHANGES.md

cylc/uiserver/resolvers.py

cylc/uiserver/schema.py

CHANGES.md

cylc/uiserver/resolvers.py

MetRonnie

Tested out by artificially changing the cylc_version value to 8.0.3 in workflow_params table, looks good

MetRonnie

Needs rebasing onto master

CHANGES.md

* Intercept error message about versions and upgrading and post it to a more helpful error message than stardard "This Cylc Play command failed" * Add a toggle for the --upgrade option of Cylc Play

Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>

MetRonnie · 2023-08-08T14:49:29Z

Any reason this can't go on 1.3.x?

oliver-sanders

Dammit, I had a pending review, sorry.

Any reason this can't go on 1.3.x?

Yeah, this could go in 1.3.x, note 1.4.0 will hopefully be released shortly.

cylc/uiserver/schema.py

cylc/uiserver/resolvers.py

Co-authored-by: Oliver Sanders <oliver.sanders@metoffice.gov.uk>

wxtim · 2023-08-22T08:52:05Z

@oliver-sanders / @MetRonnie Want to hit the merge button? We don't have separate master/1.4.x branches, so I suppose that we haven't got any major changes?

CHANGES.md

Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>

wxtim added the small label May 12, 2023

wxtim added this to the 1.3.0 milestone May 12, 2023

wxtim requested review from oliver-sanders and MetRonnie May 12, 2023 09:01

wxtim self-assigned this May 12, 2023

wxtim force-pushed the enable_upgrade branch from b2d414e to 88f6324 Compare May 12, 2023 09:03

MetRonnie reviewed May 12, 2023

View reviewed changes

CHANGES.md Outdated Show resolved Hide resolved

MetRonnie reviewed May 12, 2023

View reviewed changes

cylc/uiserver/resolvers.py Outdated Show resolved Hide resolved

cylc/uiserver/schema.py Outdated Show resolved Hide resolved

wxtim mentioned this pull request May 12, 2023

cylc play: add suggestion for --upgrade in non-interactive terminal cylc/cylc-flow#5535

Merged

8 tasks

wxtim commented May 12, 2023

View reviewed changes

CHANGES.md Outdated Show resolved Hide resolved

MetRonnie reviewed May 12, 2023

View reviewed changes

CHANGES.md Outdated Show resolved Hide resolved

cylc/uiserver/resolvers.py Outdated Show resolved Hide resolved

oliver-sanders reviewed May 15, 2023

View reviewed changes

cylc/uiserver/resolvers.py Outdated Show resolved Hide resolved

wxtim force-pushed the enable_upgrade branch from 64baccb to b7952e4 Compare May 15, 2023 09:14

wxtim requested review from oliver-sanders and MetRonnie May 15, 2023 09:15

wxtim force-pushed the enable_upgrade branch from b7952e4 to 008f8c4 Compare May 15, 2023 12:53

MetRonnie reviewed May 22, 2023

View reviewed changes

cylc/uiserver/resolvers.py Outdated Show resolved Hide resolved

cylc/uiserver/resolvers.py Outdated Show resolved Hide resolved

wxtim requested a review from MetRonnie May 22, 2023 15:16

MetRonnie approved these changes May 22, 2023

View reviewed changes

MetRonnie linked an issue May 23, 2023 that may be closed by this pull request

play: add --upgrade option #429

Closed

oliver-sanders modified the milestones: 1.3.0, 1.4.0 Jul 17, 2023

MetRonnie requested changes Jul 19, 2023

View reviewed changes

wxtim force-pushed the enable_upgrade branch from 843a8cb to 48243e2 Compare July 19, 2023 10:47

wxtim changed the base branch from 1.2.x to master July 19, 2023 10:48

wxtim force-pushed the enable_upgrade branch from 48243e2 to 5015654 Compare July 19, 2023 10:49

wxtim requested a review from MetRonnie July 19, 2023 10:49

MetRonnie approved these changes Jul 20, 2023

View reviewed changes

CHANGES.md Show resolved Hide resolved

wxtim marked this pull request as draft July 21, 2023 08:39

wxtim and others added 6 commits July 25, 2023 13:42

Handle trying to play workflows which require upgrade:

6fe84d0

* Intercept error message about versions and upgrading and post it to a more helpful error message than stardard "This Cylc Play command failed" * Add a toggle for the --upgrade option of Cylc Play

Update cylc/uiserver/schema.py

4668c9d

Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>

response to review - move the message to cylc flow

74ff886

Update cylc/uiserver/resolvers.py

b3c3d01

Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>

Update cylc/uiserver/resolvers.py

13a4f61

Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>

update CHANGES.md

b772be6

wxtim force-pushed the enable_upgrade branch from 80bf2ba to b772be6 Compare July 25, 2023 12:44

wxtim marked this pull request as ready for review July 25, 2023 12:44

MetRonnie approved these changes Jul 25, 2023

View reviewed changes

oliver-sanders reviewed Aug 10, 2023

View reviewed changes

cylc/uiserver/schema.py Show resolved Hide resolved

cylc/uiserver/resolvers.py Show resolved Hide resolved

oliver-sanders approved these changes Aug 10, 2023

View reviewed changes

Update cylc/uiserver/schema.py

f136588

Co-authored-by: Oliver Sanders <oliver.sanders@metoffice.gov.uk>

MetRonnie changed the base branch from master to 1.3.x August 22, 2023 10:30

MetRonnie modified the milestones: 1.4.0, 1.3.1 Aug 22, 2023

MetRonnie reviewed Aug 22, 2023

View reviewed changes

CHANGES.md Outdated Show resolved Hide resolved

Update CHANGES.md

25a2924

Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>

wxtim changed the title ~~Handle trying to play workflows which require upgrade:~~ Improve upgrade warnings Aug 22, 2023

MetRonnie changed the title ~~Improve upgrade warnings~~ Handle trying to play workflows which require upgrade Aug 22, 2023

MetRonnie merged commit fae09dd into cylc:1.3.x Aug 22, 2023
4 checks passed

MetRonnie mentioned this pull request Sep 4, 2023

Allow users to access cylc play --upgrade. #490

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handle trying to play workflows which require upgrade #455

Handle trying to play workflows which require upgrade #455

wxtim commented May 12, 2023 •

edited by MetRonnie

Loading

codecov-commenter commented May 12, 2023 •

edited

Loading

MetRonnie left a comment

MetRonnie left a comment

MetRonnie commented Aug 8, 2023

oliver-sanders left a comment •

edited

Loading

wxtim commented Aug 22, 2023

Handle trying to play workflows which require upgrade #455

Handle trying to play workflows which require upgrade #455

Conversation

wxtim commented May 12, 2023 • edited by MetRonnie Loading

Check List

Manual Testing

codecov-commenter commented May 12, 2023 • edited Loading

Codecov Report

MetRonnie left a comment

Choose a reason for hiding this comment

MetRonnie left a comment

Choose a reason for hiding this comment

MetRonnie commented Aug 8, 2023

oliver-sanders left a comment • edited Loading

Choose a reason for hiding this comment

wxtim commented Aug 22, 2023

wxtim commented May 12, 2023 •

edited by MetRonnie

Loading

codecov-commenter commented May 12, 2023 •

edited

Loading

oliver-sanders left a comment •

edited

Loading