opt outputs: submitted is implicitly required #5755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliver-sanders
force-pushed
the
submit-failed
branch
3 times, most recently
from
86b1041
to
a6a44e5
Compare
* This fixes a bug where submit-failed tasks were incorrectly identified as complete. * E.G. `foo:finish => bar`. * A task is incomplete if: * it finished executing without completing all required outputs * or if job submission failed and the :submit output was not optional * See: https://github.com/cylc/cylc-admin/blob/master/docs/proposal-new-output-syntax.md#output-syntax
oliver-sanders
force-pushed
the
submit-failed
branch
from
a6a44e5
to
8ff3a07
Compare
hjoliver
reviewed
Oct 5, 2023
Co-authored-by: Oliver Sanders <oliver.sanders@metoffice.gov.uk>
wxtim
approved these changes
Oct 5, 2023
hjoliver
approved these changes
Oct 5, 2023
oliver-sanders
added a commit
to oliver-sanders/cylc-flow
that referenced
this pull request
Oct 18, 2023
oliver-sanders
added a commit
to oliver-sanders/cylc-flow
that referenced
this pull request
Oct 18, 2023
8 tasks
oliver-sanders
added a commit
to oliver-sanders/cylc-flow
that referenced
this pull request
Oct 18, 2023
oliver-sanders
added a commit
to oliver-sanders/cylc-flow
that referenced
this pull request
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
foo:finish => bar.Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).CHANGES.mdentry included if this is a change that can affect users?.?.xbranch.