Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

back-compat: submitted is implicitly required #5776

Merged
merged 1 commit into from
Oct 19, 2023
Merged

back-compat: submitted is implicitly required #5776

merged 1 commit into from
Oct 19, 2023

Conversation

oliver-sanders
Copy link
Member

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • CHANGES.md entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@oliver-sanders oliver-sanders changed the base branch from master to 8.2.x October 18, 2023 16:09
@oliver-sanders oliver-sanders added this to the cylc-8.2.3 milestone Oct 18, 2023
@oliver-sanders oliver-sanders self-assigned this Oct 18, 2023
@oliver-sanders oliver-sanders added the bug Something is wrong :( label Oct 18, 2023
@oliver-sanders
back-compat: submitted is implicitly required
756f304 
* Closes cylc#5771.
* Ensure that submit-failed tasks are marked as incomplete.
* See also cylc#5755
@hjoliver hjoliver merged commit 07a330c into cylc:8.2.x Oct 19, 2023
24 of 25 checks passed
@oliver-sanders oliver-sanders deleted the 5771 branch October 23, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MetRonnie MetRonnie MetRonnie approved these changes

@hjoliver hjoliver hjoliver approved these changes

Assignees

@oliver-sanders oliver-sanders

Labels
bug Something is wrong :( small
Projects
None yet
Milestone
cylc-8.2.3
Development

Successfully merging this pull request may close these issues.

compat mode: submit-failed tasks dissappear
3 participants
@oliver-sanders @hjoliver @MetRonnie