Lint: Add a check for indentation being 4N spaces. #5772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make 'url' key optional in check specification. Document pyproject.toml fields.
There was a problem hiding this comment.
The multiple of four space check works well.
I spotted what looks like a duplicate code going through the CLi help:
U001:
"[scheduling][dependencies][<recurrence>]graph =" -> "[scheduling][graph]<recurrence> ="
U002:
"[scheduling][dependencies][<recurrence>]graph =" -> "[scheduling][graph]<recurrence> ="
oliver-sanders
requested review from
oliver-sanders
and removed request for
MetRonnie
|
@oliver-sanders U001 and U002 being the same is deliberate, but I agree, perhaps a little confusing. They are detecting two different patterns with the same underlying cause (The change from I have added a bracket with a little text to this effect to each message - hopefully that makes it OK for you? |
oliver-sanders
approved these changes
Nov 15, 2023
markgrahamdawson
previously approved these changes
Nov 16, 2023
markgrahamdawson
dismissed
their stale review
Pull request may be revisited after discussion with Tim and Oliver
markgrahamdawson
approved these changes
Nov 16, 2023
wxtim
added a commit
to wxtim/cylc
that referenced
this pull request
Dec 5, 2023
…at_runtime * upstream/master: log_vc_info: handle long command output (cylc#5821) GH Actions: limit tutorial workflow to Py3.11 remove cylc task dependencies env var (cylc#5836) Refactor.lint (cylc#5718) protobuf 4.24.4 upgrade (cylc#5828) made reinstall work on multiple workflows Fix `IndepQueueManager` test (cylc#5832) Lint: Add a check for indentation being 4N spaces. (cylc#5772)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make 'url' key optional in check specification.
Document pyproject.toml fields.
A couple of small fixes I found when looking at Cylc Lint for my talk on Thurs.
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).CHANGES.mdentry included if this is a change that can affect users?.?.xbranch.