Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protobuf 4.24 #5828

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Protobuf 4.24 #5828

merged 1 commit into from
Nov 22, 2023

Conversation

dwsutherland
Copy link
Member

@dwsutherland dwsutherland commented Nov 20, 2023

Protobuf upgrade to 4.24.4:
https://github.com/protocolbuffers/protobuf/releases/tag/v24.4
https://github.com/protocolbuffers/protobuf/releases/tag/v24.0

Support for Python 3.7 is dropped at 4.25.0

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • CHANGES.md entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@dwsutherland dwsutherland added this to the cylc-8.2.4 milestone Nov 20, 2023
@dwsutherland dwsutherland self-assigned this Nov 20, 2023
@dwsutherland dwsutherland changed the base branch from master to 8.2.x November 20, 2023 08:17
@dwsutherland dwsutherland reopened this Nov 20, 2023
@oliver-sanders
Copy link
Member

I think this should be raised on the master branch?

@dwsutherland dwsutherland changed the base branch from 8.2.x to master November 20, 2023 23:01
@oliver-sanders
Copy link
Member

(FYI, we're checking compatibility with an old platform, will get back soon)

@oliver-sanders
Copy link
Member

(new version installs fine because protobuf falls back to the Python backend)

Copy link
Member

@MetRonnie MetRonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested interacting with a workflow started under this branch (after pip installing) using a pre-running UIS, and new UIS with this version of protobuf in the environment interacting with an 8.2.3 workflow

@MetRonnie MetRonnie merged commit 1e3fe28 into cylc:master Nov 22, 2023
34 of 37 checks passed
wxtim added a commit to wxtim/cylc that referenced this pull request Dec 5, 2023
…at_runtime

* upstream/master:
  log_vc_info: handle long command output (cylc#5821)
  GH Actions: limit tutorial workflow to Py3.11
  remove cylc task dependencies env var (cylc#5836)
  Refactor.lint (cylc#5718)
  protobuf 4.24.4 upgrade (cylc#5828)
  made reinstall work on multiple workflows
  Fix `IndepQueueManager` test (cylc#5832)
  Lint: Add a check for indentation being 4N spaces. (cylc#5772)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants