Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cylc clean remote timeout improvements #5872

Merged
merged 4 commits into from
Dec 13, 2023
Merged

cylc clean remote timeout improvements #5872

merged 4 commits into from
Dec 13, 2023

Conversation

MetRonnie
Copy link
Member

@MetRonnie MetRonnie commented Dec 8, 2023 •
edited
Loading

Closes #5867

  • Increase default remote --timeout to 5 mins and allow ISO 8601 durations
  • Provide a shorter and clearer error message for remote timeouts

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • No dependency changes
  • Tests are included
  • CHANGES.md entry included if this is a change that can affect users
  • No docs needed
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@MetRonnie MetRonnie added this to the cylc-8.3.0 milestone Dec 8, 2023
@MetRonnie MetRonnie self-assigned this Dec 8, 2023
oliver-sanders
oliver-sanders reviewed Dec 8, 2023
View reviewed changes
cylc/flow/clean.py Outdated Show resolved Hide resolved
wxtim
wxtim reviewed Dec 11, 2023
View reviewed changes
Copy link
Member

@wxtim wxtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fairly happy with this. Action comments and I'll approve.

cylc/flow/clean.py Outdated Show resolved Hide resolved
cylc/flow/clean.py Outdated Show resolved Hide resolved
@MetRonnie MetRonnie marked this pull request as draft December 11, 2023 11:28
@MetRonnie MetRonnie marked this pull request as ready for review December 12, 2023 16:25
@wxtim wxtim self-requested a review December 13, 2023 11:51
@wxtim wxtim merged commit fe43c7c into cylc:master Dec 13, 2023
25 of 27 checks passed
@MetRonnie MetRonnie deleted the cylc-clean branch December 13, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxtim wxtim wxtim approved these changes

@oliver-sanders oliver-sanders oliver-sanders approved these changes

Assignees

@MetRonnie MetRonnie

Labels
None yet
Projects
None yet
Milestone
8.3.0
Development

Successfully merging this pull request may close these issues.

cylc clean timeout traceback
3 participants
@MetRonnie @oliver-sanders @wxtim