Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear Template Variables from scheduler options before reload #5996

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Feb 23, 2024

Closes #5968

Warning

Branch is based on #5868 and should not be merged before that. Merged.

This passes the manual test described in #5968, and the equivelent test with -D.

I've tried to integration and functional tests, but have hit assorted walls:

  • Functional relies on Rose and Cylc-Rose installs, it might be possible to fake a plugin for the test, but I struggled to make it work with Rose.
  • Integration makes it easier to mock the plugin, but I've struggled to mock the moving parts required without making the test a meaningless cookie-cutter inversion of the logic.
  • Given that this is about CLI interaction Functional tests make more sense IMO.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests - See explanations above.
  • CHANGES.md entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@wxtim wxtim self-assigned this Feb 23, 2024
@wxtim wxtim added this to the cylc-8.3.0 milestone Feb 23, 2024
@oliver-sanders
Copy link
Member

(note, the issue is against 8.2.x)

@oliver-sanders oliver-sanders added the bug Something is wrong :( label Feb 26, 2024
@wxtim wxtim changed the base branch from master to 8.2.x February 26, 2024 13:19
@wxtim wxtim changed the base branch from 8.2.x to master February 26, 2024 13:19
@wxtim wxtim changed the base branch from master to 8.2.x February 26, 2024 13:21
@wxtim wxtim changed the base branch from 8.2.x to master February 26, 2024 13:24
@wxtim wxtim changed the base branch from master to 8.2.x February 26, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vr: plugin options not respected when workflow is running
2 participants