Clear all Cylc Rose options after Post-Install plugin #6059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
MetRonnie
approved these changes
Apr 9, 2024
8 tasks
MetRonnie
reviewed
Apr 9, 2024
Comment on lines
+1266
to
+1273
| # Allow -S and -D and -O to take effect in Cylc VR. | ||
| # https://github.com/cylc/cylc-flow/issues/5968 | ||
| # & https://github.com/cylc/cylc-flow/issues/6058 | ||
| # TODO delete after 8.3.0 when this change will be included in | ||
| # Cylc Rose | ||
| self.options.rose_template_vars = [] | ||
| self.options.defines = [] | ||
| self.options.opt_conf_keys = [] |
There was a problem hiding this comment.
Because if we delete the other two and not this one this one will override anything the user has input.
This is probably the wrong thing to do.
|
closing this because I don't think it's the correct solution: It fixes the proximate problem and not the underlying cause. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6058 , itself a side effect of #5996.
Explanation
Cylc play ignores -S but not -O so -O overrides -S, but it shouldn't.
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).CHANGES.mdentry included if this is a change that can affect users?.?.xbranch.