clean the options with information for cylc rose after dumping thier … #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…content in rose-suite-cylc-install.conf
8 tasks
Comment on lines
+360
to
+374
| def test_CLI_opts_cleared(monkeypatch): | ||
| """The post install entry point should clear the three rose opts""" | ||
| path = 'cylc.rose.entry_points.' | ||
| monkeypatch.setattr( | ||
| f'{path}record_cylc_install_options', lambda *_, **__: False) | ||
| monkeypatch.setattr(f'{path}copy_config_file', lambda *_, **__: False) | ||
| monkeypatch.setattr(f'{path}rose_config_exists', lambda *_, **__: True) | ||
|
|
||
| opts = SimpleNamespace( | ||
| rose_template_vars=['gee', 'whiz'], | ||
| defines=['foo', 'bar'], | ||
| opt_conf_keys=['thomas', 'percy']) | ||
|
|
||
| post_install('', '', opts) | ||
| assert any(opts.__dict__.values()) is False |
There was a problem hiding this comment.
For a functional test, how about something installs and then reinstalls a workflow using the same opts object e.g:
def test_something(cylc_install_cl):
opts = SimpleNamespace(
rose_template_vars=['gee', 'whiz'],
defines=['foo', 'bar'],
opt_conf_keys=['thomas', 'percy']
)
# install
run_dir = cylc_install_cli(..., opts)
# check installed rose config
RoseConfigTree(run_dir).get(('template variables', 'gee')) == 'whatever'
# reinstall using same opts object (just like cylc-flow does)
run_dir = cylc_install_cli(..., opts)
# check the installed rose config again
RoseConfigTree(run_dir).get(('template variables', 'gee')) == 'whatever'There was a problem hiding this comment.
I don't actually think that this change makes sense, since the original bug surfaces in cylc play (which never runs the post install plugin) and not just cylc vip. I think that these two PR's may both need to be scrapped and the 8.2.x solution used after all (cylc/cylc-flow#6059).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…content in rose-suite-cylc-install.conf
Partner of cylc/cylc-flow#6060
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).CHANGES.mdentry included if this is a change that can affect users?.?.xbranch.