Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prune suicide edges fix #6096

Merged
merged 4 commits into from
May 13, 2024

Conversation

dwsutherland
Copy link
Member

@dwsutherland dwsutherland commented May 9, 2024

closes cylc/cylc-ui#1787

Some deltas we discard (if the nodes they apply to are about to be pruned), we needed to delete any associated edges too..

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • No dependency changes
  • Tests are included (or explain why tests are not needed).
  • CHANGES.md entry included if this is a change that can affect users
  • No docs PR needed
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

cylc/flow/data_store_mgr.py Outdated Show resolved Hide resolved
cylc/flow/data_store_mgr.py Outdated Show resolved Hide resolved
@MetRonnie MetRonnie added the small label May 9, 2024
dwsutherland and others added 2 commits May 9, 2024 22:50
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
@markgrahamdawson markgrahamdawson merged commit 877f96e into cylc:8.2.x May 13, 2024
@MetRonnie MetRonnie modified the milestones: 8.2.x, 8.2.7 May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :( small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suicide triggers can cause arrows to permanently disappear from graph view
3 participants