Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prune suicide edges fix #6096

Merged
merged 4 commits into from
May 13, 2024
Merged

prune suicide edges fix #6096

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
35c7e07
prune suicide edges fix
dwsutherland May 9, 2024
8ef771b
Update cylc/flow/data_store_mgr.py
dwsutherland May 9, 2024
b2e55b7
Update cylc/flow/data_store_mgr.py
dwsutherland May 9, 2024
d903e6f
Changelog [skip ci]
MetRonnie May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes.d/6096.fix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed bug that caused graph arrows to go missing in the GUI when suicide triggers are present.
6 changes: 4 additions & 2 deletions cylc/flow/data_store_mgr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1972,10 +1972,12 @@ def prune_pruned_updated_nodes(self):
node = tp_added[tp_id]
else:
continue
for j_id in list(node.jobs) + list(tp_updated[tp_id].jobs):
update_node = tp_updated.pop(tp_id)
for j_id in list(node.jobs) + list(update_node.jobs):
if j_id in j_updated:
del j_updated[j_id]
del tp_updated[tp_id]
self.n_window_edges.difference_update(update_node.edges)
self.deltas[EDGES].pruned.extend(update_node.edges)
self.pruned_task_proxies.clear()

def update_family_proxies(self):
Expand Down