Lint: Tell users that backslashes are no longer necessary after => & | #6459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxtim
force-pushed
the
lint.6456.fewer_line_continuations
branch
from
6f7c711 to
4f3f8f1
Compare
oliver-sanders
requested review from
markgrahamdawson
and removed request for
MetRonnie
MetRonnie
reviewed
Nov 18, 2024
cylc/flow/scripts/lint.py
Outdated
Comment on lines
724
to
729
| 'U017': { | ||
| 'short': ( | ||
| '`&` and `|` are line continuations without `\\`' | ||
| ), | ||
| FUNCTION: re.compile(r'[&|]\s*\\').findall | ||
| }, |
There was a problem hiding this comment.
I think this should be part of S014
There was a problem hiding this comment.
I think that they should in time be, but at the moment they will not work if you are using compat mode Cylc 8 and Cylc 7 in Para||el, so I think that they should be an upgrade until Cylc 7 is more dead than it currently is.
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
markgrahamdawson
approved these changes
Nov 21, 2024
hjoliver
requested changes
Nov 21, 2024
Co-authored-by: Hilary James Oliver <hilary.j.oliver@gmail.com>
hjoliver
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit: superseded by #6493
Closes #6456
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).