cylc lint: S015/U017 line continuation chars
#6493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
Co-authored-by: Hilary James Oliver <hilary.j.oliver@gmail.com>
8 tasks
MetRonnie
reviewed
Nov 25, 2024
changes.d/6459.feat.md
Outdated
There was a problem hiding this comment.
It's ok to reference the issue rather than the PR right? Issues are generally more user-facing descriptions of the problem so may serve better for user documentation.
MetRonnie
changed the title
cylc lint: S015/U017 line continuation chars
hjoliver
requested changes
Nov 25, 2024
Co-authored-by: Hilary James Oliver <hilary.j.oliver@gmail.com>
I agree with that statement. If you assigned 3 other reviewers for good reasons we can always open another tweak PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #6459 which blocks sync PRs
Otherwise the same diff.
Seealso @MetRonnie's Comment on #6459 (comment)
Probably OK to be a single review since it's a copy of an already accepted PR.