compat mode ignored

[oliver-sanders]

A bug which can be replicated by:

• Running a Cylc 7 workflow under Cylc 8 compat mode.
• Which contains an fcm_make task.
• And a :finish trigger.

This should do it:

# suite.rc
[scheduling]
  [[graph]]
    R1 = fcm_make:finish => fin

Due to the way the workflow config is loaded from the log/config/flow-processed.cylc file, the Cylc 7 compat mode check is not being performed correctly causing the config to think it is not in compat mode.

This check is performed automatically by WorkflowConfig.__init__ so may require an upstream change to cylc-flow, hence 1.4.0.

Introduced by #302

[wxtim]

I cannot replicate the bug with your example.

[oliver-sanders]

The error will be raised when the fcm_make task runs. It will need to be a "real" fcm_make task, not just a task called fcm_make, and it will need a sufficiently valid configuration that it gets far enough to trigger the loading of the workflow config. I don't have an example for this, you could try to butcher a rose-stem workflow to get one.

[wxtim]

I have now replicated this error using

/metomi/rose/t/rose-task-run/26-app-fcm-make-new-mode-with-cont

with graph modified to

            hello-make:finish & hello-make => fin

Which should be ok in compat mode.