-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
platforms: use processed workflow config #302
Conversation
Kicked off Rose tests against this branch: https://github.com/metomi/rose/actions/runs/8325392017 Not playing ball because of lint tests, reviewers will need to check manually, note, 2.1.x branch. Suggest the following: t/rose-task-run/04-run-path-empty.t |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Read code change
- Checked where code is likely to touch the database using
./t/rose-task-run/04-run-path-empty
- Run test manually.
* When retrieving the platform used by a task, use the processed workflow config rather than processing the config from scratch. * This avoids the need to access the DB to extract template variables (workflow params) which could cause public DB locking issues.
bf02254
to
8996ee4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-ran tests
I think this will fix a bug we've just run into at NIWA. We have a custom Python module that determines Slurm accounting code from a project code in the environment. The |
That makes sense. |
Check List
CONTRIBUTING.md
and added my name as a Code Contributor.setup.cfg
(andconda-environment.yml
if present).CHANGES.md
entry included if this is a change that can affect users?.?.x
branch.