Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that fileinstall doesn't fail given the status of asyncio loop #130

Merged
merged 7 commits into from
Apr 5, 2022
Merged

Ensure that fileinstall doesn't fail given the status of asyncio loop #130

merged 7 commits into from
Apr 5, 2022

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Apr 4, 2022 •
edited
Loading

These changes close #129

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to setup.cfg.
  • Appropriate tests are included (unit and/or functional).
  • Appropriate change log entry included.
  • No documentation update required.

@wxtim wxtim self-assigned this Apr 4, 2022
@wxtim wxtim added this to the 1.0.3 milestone Apr 4, 2022
oliver-sanders
oliver-sanders reviewed Apr 4, 2022
View reviewed changes
Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, need to test.

cylc/rose/entry_points.py Show resolved Hide resolved
oliver-sanders
oliver-sanders approved these changes Apr 4, 2022
View reviewed changes
Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that the test fails on master and passes on this branch.

@wxtim @oliver-sanders
Update cylc/rose/entry_points.py
e0d9792 
Co-authored-by: Oliver Sanders <oliver.sanders@metoffice.gov.uk>
@oliver-sanders
Copy link
Member

There's one flake8 issue that's blocking the tests from running, could you sneak the fix in.

@wxtim
flake8
9392b79
@wxtim
Merge branch 'fix_async_bug' of github.com:wxtim/cylc-rose into fix_a…
5bbd9be 
…sync_bug

* 'fix_async_bug' of github.com:wxtim/cylc-rose:
  Update cylc/rose/entry_points.py
@wxtim
Copy link
Member Author

wxtim commented Apr 4, 2022 •
edited
Loading

Will not pass tests until #131 is merged.

wxtim
wxtim commented Apr 5, 2022
View reviewed changes
tests/test_config_node.py Outdated Show resolved Hide resolved
@wxtim
Response to review
4a0093e 
- Properly fixed a flake8 fail
- Added new lines at end of files.
datamel
datamel approved these changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@datamel datamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tim. Working well for me.

@oliver-sanders oliver-sanders merged commit c235c4b into cylc:master Apr 5, 2022
@oliver-sanders oliver-sanders added the bug Something isn't working label Apr 5, 2022
@wxtim wxtim deleted the fix_async_bug branch April 5, 2022 09:31
@wxtim wxtim mentioned this pull request Apr 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliver-sanders oliver-sanders oliver-sanders approved these changes

@datamel datamel datamel approved these changes

Assignees

@wxtim wxtim

Labels
bug Something isn't working
Projects
None yet
Milestone
1.0.3
Development

Successfully merging this pull request may close these issues.

cylc reinstall no current event loop error
3 participants
@wxtim @oliver-sanders @datamel