Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make test_pre_configure[template engine conflict] less specific #131

Merged
merged 2 commits into from
Apr 4, 2022
Merged

Make test_pre_configure[template engine conflict] less specific #131

merged 2 commits into from
Apr 4, 2022

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Apr 4, 2022

to allow changed Parsec error message to be accepted by the test.

Broken by this comment in #4720.

This is a small change with no associated Issue.

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to setup.cfg.
  • Does not need tests (itself a test change).
  • No change log entry required - test fix.
  • No documentation update required.

@wxtim
Make test_pre_configure[template engine conflict] less specific to al…
15e5e7a 
…low changed Parsec error message to be accepted bythe test.
@wxtim wxtim self-assigned this Apr 4, 2022
@wxtim wxtim added this to the 1.0.3 milestone Apr 4, 2022
@wxtim wxtim requested a review from MetRonnie April 4, 2022 15:02
@wxtim wxtim added the small label Apr 4, 2022
@wxtim wxtim mentioned this pull request Apr 4, 2022
Merged
7 tasks
@MetRonnie MetRonnie merged commit 5c35d9b into cylc:master Apr 4, 2022
@wxtim wxtim deleted the fix.test_broken_by_error_message branch April 5, 2022 06:13
@wxtim wxtim mentioned this pull request Apr 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MetRonnie MetRonnie MetRonnie approved these changes

Assignees

@wxtim wxtim

Labels
small
Projects
None yet
Milestone
1.0.3
Development

Successfully merging this pull request may close these issues.
2 participants
@wxtim @MetRonnie