removed the installed state

[oliver-sanders]

PR trio: cylc/cylc-flow#4459, cylc/cylc-uiserver#256, #805

• The installed state was the same as "stopped" but with the additional
  information that the workflow had not yet been run.
• Added this information to the workflow status message in cylc-uiserver
  (as it is offline information).
• Improved the workflow status message provided by cylc-flow.
• Put the status message into the UI toolbar.
  

Requirements check-list

• I have read CONTRIBUTING.md and added my name as a Code Contributor.
• Contains logically grouped changes (else tidy your branch by rebase).
• Does not contain off-topic changes (use other PRs for other changes).
• Appropriate tests are included (unit and/or functional).
• No change log entry required (why? e.g. invisible to users).
• No documentation update required.

[codecov-commenter]

Codecov Report

Merging #805 (f1e4a8f) into master (bc7f5ff) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #805   +/-   ##
=======================================
  Coverage   90.96%   90.96%           
=======================================
  Files          84       84           
  Lines        1672     1672           
  Branches      105      106    +1     
=======================================
  Hits         1521     1521           
  Misses        121      121           
  Partials       30       30           

Flag	Coverage Δ
e2e	77.81% <100.00%> (ø)
unittests	81.60% <ø> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/components/cylc/gscan/GScan.vue	90.62% <ø> (ø)
src/components/cylc/gscan/WorkflowIcon.vue	100.00% <ø> (ø)
src/graphql/queries.js	100.00% <ø> (ø)
src/model/WorkflowState.model.js	100.00% <ø> (ø)
src/components/cylc/workflow/Toolbar.vue	78.94% <100.00%> (+1.16%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc7f5ff...f1e4a8f. Read the comment docs.

[kinow]

Thanks! Does it supersede #804 too?

[hjoliver]

What is "dimished" meant to be:

• diminished?
• dimmed?
• dimmish?

[hjoliver]

A couple of issues (which could be considered off-topic for this PR):

• the status message for "Stopping" is too verbose for the tool bar
• it doesn't update from Stopping to Stopped (stays Stopping for ever)
• it's not consistent with the gscan tooltip

[oliver-sanders]

Good catch on the stopping status, will take a look, would like to fix that on this/these PR(s).

Should be able to convert the GScan tooltip to use this summary string too.

[oliver-sanders]

• [flow] Fixed a bug in the data store where the workflow status wasn't updated to stopping (unless something else triggered an update).
• [uis] Added logic to change the status from * to stopped on receiving the shutdown message.
• [ui] Added the status message to the gscan workflow icon tooltips.

opened: cylc/cylc-uiserver#257

[kinow]

Code looks good to me! Will leave final functional review to @hjoliver 👍

[hjoliver]

Tested, all good now 👍

[hjoliver]

(For a follow-up: the tool bar icons stay as greyed-out "pause" and "stop" after stopping; the "play" button should reappear).

[hjoliver]

(Two approvals, but waiting for changes in the sibling PR)

[oliver-sanders]

(For a follow-up: the tool bar icons stay as greyed-out "pause" and "stop" after stopping; the "play" button should reappear).

Play (as in play from stopped) is not implemented in the toolbar (because the mutation didn't exist when the toolbar icons were developed!), should be sorted in #806

[hjoliver]

Merging now as the sibling PRs are in.