removed the installed state #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Codecov Report
@@ Coverage Diff @@
## master #256 +/- ##
==========================================
+ Coverage 75.00% 75.06% +0.06%
==========================================
Files 11 11
Lines 736 738 +2
Branches 125 126 +1
==========================================
+ Hits 552 554 +2
Misses 158 158
Partials 26 26
Continue to review full report at Codecov.
|
6 tasks
oliver-sanders
force-pushed
the
remove-installed-state
branch
from
5ce2817 to
16193f9
Compare
|
(mypy failing due to comparing against cylc-flow master branch) |
hjoliver
approved these changes
Oct 11, 2021
oliver-sanders
force-pushed
the
remove-installed-state
branch
from
16193f9 to
4e3eeb7
Compare
opened: #257 |
hjoliver
approved these changes
Oct 13, 2021
* The installed state was the same as "stopped" but with the additional information that the workflow had not yet been run. * Added this information to the workflow status message in cylc-uiserver (as it is offline information). * Improved the workflow status message provided by cylc-flow. * Put the status message into the UI toolbar.
oliver-sanders
force-pushed
the
remove-installed-state
branch
from
4e3eeb7 to
feaa1d1
Compare
hjoliver
approved these changes
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR trio: cylc/cylc-flow#4459, #256, cylc/cylc-ui#805
information that the workflow had not yet been run.
(as it is offline information).
Requirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.