Skip to content

Commit

Permalink
fix: show info message correctly on "record your first run ui" (#22413)
Browse files Browse the repository at this point in the history 
Co-authored-by: Rachel <rachel@cypress.io>
  • Loading branch information
@sainthkh @rachelruderman
sainthkh and rachelruderman authored Jul 18, 2022
1 parent 7c4d5e5 commit 1643161
Show file tree
Hide file tree
Showing 2 changed files with 58 additions and 21 deletions.
33 changes: 33 additions & 0 deletions packages/app/src/runs/RunsConnectSuccessAlert.spec.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,37 @@ describe('<RunConnectSuccessAlert />', { viewportHeight: 400 }, () => {
},
})
})

// https://github.com/cypress-io/cypress/issues/21856
describe('resposive design', () => {
it('small screen (width < md(768px))', () => {
cy.mountFragment(RunsConnectSuccessAlertFragmentDoc, {
render: (gqlVal) => {
return (
<div class="bg-gray-100 h-screen p-3">
<RunsConnectSuccessAlert gql={gqlVal} />
</div>
)
},
})

cy.viewport(400, 800)
cy.percySnapshot()
})

it('wide screen (width >= md(768px))', () => {
cy.mountFragment(RunsConnectSuccessAlertFragmentDoc, {
render: (gqlVal) => {
return (
<div class="bg-gray-100 h-screen p-3">
<RunsConnectSuccessAlert gql={gqlVal} />
</div>
)
},
})

cy.viewport(1000, 800)
cy.percySnapshot()
})
})
})
46 changes: 25 additions & 21 deletions packages/app/src/runs/RunsConnectSuccessAlert.vue
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,28 +6,32 @@
dismissible
:title="t('runs.connectSuccessAlert.title')"
>
<p class="flex px-16px pt-16px leading-24px items-center">
<i-cy-arrow-outline-right_x16 class="h-16px mr-8px w-16px inline align-middle icon-dark-jade-500" />
<i18n-t
scope="global"
keypath="runs.connectSuccessAlert.item1"
>
<template #projectId>
<span class="font-normal m-4px text-jade-600">projectId</span>
</template>
<template #configFile>
<span class="font-normal m-4px text-jade-600">{{ configFilePath }}</span>
</template>
</i18n-t>
<p class="flex px-16px pt-16px leading-24px md:items-center">
<i-cy-arrow-outline-right_x16 class="h-16px mr-8px w-16px inline align-middle icon-dark-jade-500 mt-4px md:mt-0" />
<span>
<i18n-t
scope="global"
keypath="runs.connectSuccessAlert.item1"
>
<template #projectId>
<span class="font-normal text-jade-600">projectId</span>
</template>
<template #configFile>
<span class="font-normal text-jade-600">{{ configFilePath }}</span>
</template>
</i18n-t>
</span>
</p>
<p class="flex px-16px pt-16px pb-16px leading-24px items-center">
<i-cy-arrow-outline-right_x16 class="h-16px mr-8px w-16px inline align-middle icon-dark-jade-500" />
<i18n-t
scope="global"
keypath="runs.connectSuccessAlert.item2"
>
<span class="font-normal m-4px text-jade-600">{{ configFilePath }}</span>
</i18n-t>
<p class="flex px-16px pt-16px pb-16px leading-24px md:items-center">
<i-cy-arrow-outline-right_x16 class="h-16px mr-8px w-16px inline align-middle icon-dark-jade-500 mt-4px md:mt-0" />
<span>
<i18n-t
scope="global"
keypath="runs.connectSuccessAlert.item2"
>
<span class="font-normal text-jade-600">{{ configFilePath }}</span>
</i18n-t>
</span>
</p>
</Alert>
</template>
Expand Down

5 comments on commit 1643161

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 1643161 Jul 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux x64 version of the Test Runner.

Learn more about this pre-release platform-specific build at https://on.cypress.io/installing-cypress#Install-pre-release-version.

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/10.4.0/linux-x64/develop-1643161559daf0ad951e76b3d77b213669002597/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 1643161 Jul 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux arm64 version of the Test Runner.

Learn more about this pre-release platform-specific build at https://on.cypress.io/installing-cypress#Install-pre-release-version.

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/10.4.0/linux-arm64/develop-1643161559daf0ad951e76b3d77b213669002597/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 1643161 Jul 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin arm64 version of the Test Runner.

Learn more about this pre-release platform-specific build at https://on.cypress.io/installing-cypress#Install-pre-release-version.

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/10.4.0/darwin-arm64/develop-1643161559daf0ad951e76b3d77b213669002597/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 1643161 Jul 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin x64 version of the Test Runner.

Learn more about this pre-release platform-specific build at https://on.cypress.io/installing-cypress#Install-pre-release-version.

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/10.4.0/darwin-x64/develop-1643161559daf0ad951e76b3d77b213669002597/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 1643161 Jul 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the win32 x64 version of the Test Runner.

Learn more about this pre-release platform-specific build at https://on.cypress.io/installing-cypress#Install-pre-release-version.

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/10.4.0/win32-x64/develop-1643161559daf0ad951e76b3d77b213669002597/cypress.tgz

Please sign in to comment.