-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: show info message correctly on "record your first run ui" #22413
Conversation
Thanks for taking the time to open a PR!
|
<span class="font-normal m-4px text-jade-600">projectId</span> | ||
</template> | ||
<template #configFile> | ||
<span class="font-normal m-4px text-jade-600">{{ configFilePath }}</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<span class="font-normal m-4px text-jade-600">projectId</span> | |
</template> | |
<template #configFile> | |
<span class="font-normal m-4px text-jade-600">{{ configFilePath }}</span> | |
<span class="font-normal text-jade-600">projectId</span> | |
</template> | |
<template #configFile> | |
<span class="font-normal text-jade-600">{{ configFilePath }}</span> |
scope="global" | ||
keypath="runs.connectSuccessAlert.item2" | ||
> | ||
<span class="font-normal m-4px text-jade-600">{{ configFilePath }}</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<span class="font-normal m-4px text-jade-600">{{ configFilePath }}</span> | |
<span class="font-normal text-jade-600">{{ configFilePath }}</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution @sainthkh ! Just added some suggestions to remove the margin around the file path names:
@sainthkh it'd be great to add a test here as well. Would you mind adding one to |
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving! I tried hard to get the GitHub checks green but known flake been gettin' in the way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
User facing changelog
Show info message correctly on "record your first run ui".
Additional details
Steps to test
N/A
How has the user experience changed?
Before:
After:
PR Tasks
cypress-documentation
?type definitions
?