Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show info message correctly on "record your first run ui" #22413

Merged
merged 4 commits into from
Jul 18, 2022

Conversation

sainthkh
Copy link
Contributor

User facing changelog

Show info message correctly on "record your first run ui".

Additional details

  • Why was this change necessary? => Message is hard to read on small viewport.
  • What is affected by this change? => N/A
  • Any implementation details to explain? => I tweaked the HTML structure and added some classes.

Steps to test

N/A

How has the user experience changed?

Before:

image

After:

image

PR Tasks

  • Have tests been added/updated? => I intentionally didn't add test because the problem is in HTML structure.
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 21, 2022

Thanks for taking the time to open a PR!

@sainthkh sainthkh marked this pull request as ready for review June 21, 2022 07:07
@rachelruderman rachelruderman self-requested a review June 24, 2022 15:48
Comment on lines 17 to 20
<span class="font-normal m-4px text-jade-600">projectId</span>
</template>
<template #configFile>
<span class="font-normal m-4px text-jade-600">{{ configFilePath }}</span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<span class="font-normal m-4px text-jade-600">projectId</span>
</template>
<template #configFile>
<span class="font-normal m-4px text-jade-600">{{ configFilePath }}</span>
<span class="font-normal text-jade-600">projectId</span>
</template>
<template #configFile>
<span class="font-normal text-jade-600">{{ configFilePath }}</span>

scope="global"
keypath="runs.connectSuccessAlert.item2"
>
<span class="font-normal m-4px text-jade-600">{{ configFilePath }}</span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<span class="font-normal m-4px text-jade-600">{{ configFilePath }}</span>
<span class="font-normal text-jade-600">{{ configFilePath }}</span>

Copy link
Contributor

@rachelruderman rachelruderman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @sainthkh ! Just added some suggestions to remove the margin around the file path names:

Screen Shot 2022-06-29 at 10 29 16 AM

@rachelruderman
Copy link
Contributor

@sainthkh it'd be great to add a test here as well. Would you mind adding one to packages/app/src/runs/RunsConnectSuccessAlert.spec.tsx using cy.viewport() to recreate the small viewport and calling cy.percySnapshot() so we can protect against visual regressions? 🙏

@cypress
Copy link

cypress bot commented Jul 5, 2022



Test summary

37721 0 456 0Flakiness 11


Run details

Project cypress
Status Passed
Commit 7a2ef37
Started Jul 15, 2022 6:28 PM
Ended Jul 15, 2022 6:52 PM
Duration 23:40 💡
OS Linux Debian - 10.11
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

actions/click.cy.js Flakiness
1 ... > scroll-behavior > can scroll to and click elements in html with scroll-behavior: smooth
xhr.cy.js Flakiness
1 ... > logs request + response headers
2 ... > logs Method, Status, URL, and XHR
3 ... > logs response
4 ... > logs request + response headers
This comment includes only the first 5 flaky tests. See all 11 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Contributor

@rachelruderman rachelruderman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving! I tried hard to get the GitHub checks green but known flake been gettin' in the way

Copy link
Contributor

@mike-plummer mike-plummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Record your first run UI doesn't display well on smaller width screens
4 participants