fix: (driver) add null check for browserRequestId on responses for …

…`cy.wait` (#28713)

cli/CHANGELOG.md

@@ -15,6 +15,7 @@ _Released 1/16/2024 (PENDING)_
 - Fixed asset capture for Test Replay for requests that are routed through service workers. This addresses an issue where styles were not being applied properly in Test Replay and `cy.intercept` was not working properly for requests in this scenario. Fixes [#28516](https://github.com/cypress-io/cypress/issues/28516).
 - Fixed an issue where visiting an `http://` site would result in an infinite reload/redirect loop in Chrome 114+. Fixes [#25891](https://github.com/cypress-io/cypress/issues/25891).
 - Fixed an issue where requests made from extra tabs do not include their original headers. Fixes [#28641](https://github.com/cypress-io/cypress/issues/28641).
+- Fixed an issue where `cy.wait()` would sometimes throw an error reading a property of undefined when returning responses. Fixes [#28233](https://github.com/cypress-io/cypress/issues/28233).
 
 **Performance:**
 

packages/driver/src/cy/commands/waiting.ts

@@ -254,6 +254,10 @@ export default (Commands, Cypress, cy, state) => {
  // responses are sorted in the order the user specified them. if there are multiples of the same
  // alias awaited, they're sorted in execution order
  resp.sort((a, b) => {
+ if (!a.browserRequestId || !b.browserRequestId) {
+ return 0
+ }
+
  // sort responses based on browser request ID
  const requestIdSuffixA = a.browserRequestId.split('.').length > 1 ? a.browserRequestId.split('.')[1] : a.browserRequestId
  const requestIdSuffixB = b.browserRequestId.split('.').length > 1 ? b.browserRequestId.split('.')[1] : b.browserRequestId