fix: (driver) add null check for browserRequestId on responses for cy.wait

[astone123]

• Closes cy.wait on an array return TypeError Cannot read property 'split' of undefined line 136007:55 #28233

Additional details

In #27806, we added sorting to the list of responses that we get in the wait command. The sorting algorithm uses the browserRequestId attribute to sort responses with the same aliases and return them in the order in which they were received by the browser.

Sometimes this attribute isn't defined on the responses which causes us to throw an error when we call .split on undefined. This PR updates the sorting logic to just return the responses with the original sort order if either of the requests that we're comparing don't have a browserRequestId.

Steps to test

I wasn't able to actually reproduce this - but adding the null check should at least make it so that we don't throw if the response doesn't have the expected properties.

How has the user experience changed?

PR Tasks

• Have tests been added/updated?
• [na] Has a PR for user-facing changes been opened in cypress-documentation?
• [na] Have API changes been updated in the type definitions?

[cypress]

5 flaky tests on run #53495 ↗︎

0

811

10

0

5

Details:

remove unnecessary operator
Project: cypress	Commit: 80e0f2c29f
Status: Passed	Duration: 12:20 💡
Started: Jan 12, 2024 6:32 PM	Ended: Jan 12, 2024 6:44 PM

  debug.cy.ts • 1 flaky test • app-e2e

View Output

Test		Artifacts
App - Debug Page > shows information about a failed spec		Test Replay Screenshots

  runs.cy.ts • 1 flaky test • app-e2e

View Output

Test		Artifacts
... > opens the run page if a run is clicked		Test Replay Screenshots

  runner/sessions.ui.cy.ts • 1 flaky test • app-e2e

View Output

Test		Artifacts
runner/cypress sessions.ui.spec > recreates session		Test Replay Screenshots

  specs_list_e2e.cy.ts • 1 flaky test • app-e2e

View Output

Test		Artifacts
... > saves the filter when navigating to a spec and back		Test Replay Screenshots

  specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e

View Output

Test		Artifacts
App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs		Test Replay Screenshots

Review all test suite changes for PR #28713 ↗︎

[AtofStryker]

is there a way we can add a test for this?

[astone123]

@AtofStryker I'm not really sure how to test this - I guess I could break the sort function out and unit test it? 😬

[AtofStryker]

@AtofStryker I'm not really sure how to test this - I guess I could break the sort function out and unit test it? 😬

I saw you were able to reproduce it. Is it something that happens intermittently or can you reproduce it every single time?

[astone123]

I am not able to reproduce it. Looks like for this person it only happens for a specific test? #28233 (comment). Others say that it happens intermittently

[AtofStryker]

@astone123 OK I read that wrong 😂 . I think its a good guess that this would fix there issue, but should be build a binary to be sure to have them test?

[cypress-bot]

Released in 13.6.3.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.6.3, please open a new issue.