Skip to content

Commit

Permalink
fix: adds a description for the JIT experiment which was overlooked o…
Browse files Browse the repository at this point in the history
…n initial implementation [run ci] (#30128)
  • Loading branch information
AtofStryker committed Aug 28, 2024
1 parent 0f77220 commit f6e7af9
Show file tree
Hide file tree
Showing 5 changed files with 23 additions and 0 deletions.
8 changes: 8 additions & 0 deletions cli/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,12 @@
<!-- See the ../guides/writing-the-cypress-changelog.md for details on writing the changelog. -->
## 13.14.1

_Released 8/29/2024 (PENDING)_

**Bugfixes:**

- Fixed an issue where no description was available for the `experimentalJustInTimeCompile` feature inside the Cypress application settings page. Addresses [#30126](https://github.com/cypress-io/cypress/issues/30126).

## 13.14.0

_Released 8/27/2024_
Expand Down
7 changes: 7 additions & 0 deletions packages/app/cypress/e2e/settings.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,13 @@ describe('App: Settings', () => {
})
})
})

// makes sure all experiments have an i18n header and description available.
// @see https://github.com/cypress-io/cypress/issues/30126.
cy.get('[data-cy="settings-experiments"] [role="row"][data-cy^="experiment-"]').each((experimentRow) => {
cy.wrap(experimentRow[0]).get('[data-cy="experimentName"]').should('not.contain.text', 'settingsPage.')
cy.wrap(experimentRow[0]).get('[data-cy="experimentDescription"]').should('not.contain.text', 'settingsPage.')
})
})

it('shows the Resolved Configuration section', () => {
Expand Down
2 changes: 2 additions & 0 deletions packages/app/src/settings/project/ExperimentRow.vue
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
<h3
class="inline text-indigo-500 text-md"
role="rowheader"
data-cy="experimentName"
>
{{ experiment.name }}
</h3>
Expand All @@ -22,6 +23,7 @@
<span
ref="descriptionRef"
class="description children:text-sm children:leading-[24px]"
data-cy="experimentDescription"
v-html="markdown"
/>
</span>
Expand Down
4 changes: 4 additions & 0 deletions packages/frontend-shared/src/locales/en-US.json
Original file line number Diff line number Diff line change
Expand Up @@ -609,6 +609,10 @@
"name": "Single tab run mode",
"description": "Runs all component specs in a single tab, trading spec isolation for faster run mode execution."
},
"experimentalJustInTimeCompile": {
"name": "Just-In-Time compiling",
"description": "Enables Just-In-Time (JIT) compiling for component testing, which will only compile assets related to the spec before the spec is run. Currently supported for Vite and Webpack."
},
"experimentalSourceRewriting": {
"name": "Source rewriting",
"description": "Enables AST-based JS/HTML rewriting. This may fix issues caused by the existing regex-based JS/HTML replacement algorithm. See [#5273](https://github.com/cypress-io/cypress/issues/5273) for details."
Expand Down
2 changes: 2 additions & 0 deletions packages/server/lib/experiments.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ interface StringValues {
const _summaries: StringValues = {
experimentalFetchPolyfill: 'Polyfills `window.fetch` to enable Network spying and stubbing.',
experimentalInteractiveRunEvents: 'Allows listening to the `before:run`, `after:run`, `before:spec`, and `after:spec` events in the plugins file during interactive mode.',
experimentalJustInTimeCompile: 'Just-In-Time compiling',
experimentalModifyObstructiveThirdPartyCode: 'Applies `modifyObstructiveCode` to third party `.html` and `.js`, removes subresource integrity, and modifies the user agent in Electron.',
experimentalSkipDomainInjection: 'Disables setting document.domain to the document\'s super domain on injection.',
experimentalSourceRewriting: 'Enables AST-based JS/HTML rewriting. This may fix issues caused by the existing regex-based JS/HTML replacement algorithm.',
Expand All @@ -77,6 +78,7 @@ const _summaries: StringValues = {
const _names: StringValues = {
experimentalFetchPolyfill: 'Fetch Polyfill',
experimentalInteractiveRunEvents: 'Interactive Mode Run Events',
experimentalJustInTimeCompile: 'Enables Just-In-Time (JIT) compiling for component testing, which will only compile assets related to the spec before the spec is run. Currently supported for Vite and Webpack.',
experimentalModifyObstructiveThirdPartyCode: 'Modify Obstructive Third Party Code',
experimentalSkipDomainInjection: 'Use Default document.domain',
experimentalSingleTabRunMode: 'Single Tab Run Mode',
Expand Down

3 comments on commit f6e7af9

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on f6e7af9 Aug 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/13.14.1/linux-x64/develop-f6e7af954bf220cc83ffd545ee827cc722c36824/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on f6e7af9 Aug 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux arm64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/13.14.1/linux-arm64/develop-f6e7af954bf220cc83ffd545ee827cc722c36824/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on f6e7af9 Aug 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/13.14.1/darwin-x64/develop-f6e7af954bf220cc83ffd545ee827cc722c36824/cypress.tgz

Please sign in to comment.