fix: adds a description for the JIT experiment #30128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtofStryker
force-pushed
the
fix/add_experiment_description_jit
branch
from
e154b45 to
c495292
Compare
AtofStryker
requested review from
jennifer-shehane,
mschile,
ryanthemanuel and
cacieprins
AtofStryker
force-pushed
the
fix/add_experiment_description_jit
branch
from
c495292 to
f0d68e8
Compare
mschile
approved these changes
Aug 28, 2024
ryanthemanuel
approved these changes
Aug 28, 2024
…n initial implementation [run ci]
AtofStryker
force-pushed
the
fix/add_experiment_description_jit
branch
from
f0d68e8 to
8ab02e6
Compare
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
fix/add_experiment_description_jit
|
| Run status |
|
| Run duration | 52m 46s |
| Commit |
|
| Committer | AtofStryker |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
5
|
Pending
|
1328
|
Skipped
|
0
|
Passing
|
29403
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
45.04%
|
|
|---|---|
|
Untested elements
|
200
|
|
Tested elements
|
168
|
Accessibility
91.22%
|
|
|---|---|
|
Failed rules
|
5 critical
10 serious
2 moderate
2 minor
|
|
Failed elements
|
947
|
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Adds a header and description for the JIT experiment that was released yesterday. I accidentally overlooked this on the initial implementation. Since I believe I have done this twice now with two separate experiments, I have added a regression test in
settings.cy.tsthat checks the settings page in the app to make sure all experiments have an i18n value and will fail otherwise. I am hoping this test catches this problem in the future.Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?