Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output warnings/errors in Standard Output when recording if limits reached. #1689

Closed
4 tasks done
jennifer-shehane opened this issue May 8, 2018 · 2 comments
Closed
4 tasks done
Assignees
Milestone

Comments

@jennifer-shehane
Copy link
Member

jennifer-shehane commented May 8, 2018

When our new billing portal is deployed, there will be warnings/errors when recording tests if limits reached. This will never affect test runs where the --record flag is omitted.

step 1

  • Grace Period warning over test recordings warning FREE_PLAN_IN_GRACE_PERIOD_EXCEEDS_MONTHLY_PRIVATE_TESTS
  • Over test recordings warning (paid plan) FREE_PLAN_EXCEEDS_MONTHLY_PRIVATE_TESTS

step 2

After doing warnings, extend handle 402 errors from the API which will have errors

  • Over test recordings error

Parallel runs TBD

  • Parallel flag warning/error (TBD)

This logic is similar to the custom errors here

switch err.statusCode

only now we need to handle even successful 200 response, because it will have warnings list attached postRunResponse@2.1.0. The error codes are listed for now here: https://github.com/cypress-io/cypress-api/wiki/Errors#warnings-when-creating-a-run-build

@brian-mann
Copy link
Member

Remove the logic regarding the warning displayed when an organization is in a grace period but underneath the 500 test run limits

@brian-mann brian-mann modified the milestones: Sprint 1, Sprint 2 Sep 10, 2018
@chrisbreiding chrisbreiding modified the milestones: Sprint 2, Sprint 3 Sep 17, 2018
@chrisbreiding chrisbreiding modified the milestones: Sprint 3, Sprint 4 Sep 24, 2018
brian-mann pushed a commit that referenced this issue Nov 6, 2018
Closes #1689 

The error/warning messages need work and the properties used (daysLeft, limit, etc) need to be aligned with the API once implemented.
@brian-mann
Copy link
Member

brian-mann commented Nov 19, 2018

Released in 3.1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants