Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warnings/errors for recording limits #2397

Merged
merged 19 commits into from
Nov 6, 2018

Conversation

chrisbreiding
Copy link
Contributor

Closes #1689

The error/warning messages need work and the properties used (daysLeft, limit, etc) need to be aligned with the API once implemented.

@bahmutov
Copy link
Contributor

I like the messages, and there are still 2 TODO: labels there

@chrisbreiding
Copy link
Contributor Author

Yes, I'm not sure what kind of messaging we want around how to increase the limit or whether we want to tell them they can not record. cc/ @brian-mann

@jennifer-shehane
Copy link
Member

jennifer-shehane commented Sep 11, 2018

Free plan exceeded limit (in grace period) 200

You've used {monthlyLimitPrivateTests} private test recordings this month, the limit under your free plan.

Your plan is now in a grace period, which means your tests will still be recorded until {gracePeriodEnds}. Please upgrade your plan to continue recording tests on the Cypress Dashboard in the future.

https://on.cypress.io/dashboard/organizations/{ordId}/billing

Free plan exceeded limit 402

You've used {monthlyLimitPrivateTests} private test recordings this month, the limit under your free plan.

To continue recording tests this month you must upgrade your account. Please visit your billing to upgrade to another billing plan.

https://on.cypress.io/dashboard/organizations/{ordId}/billing

Paid plan exceeded limit

You've used {monthlyLimitPrivateTests} private test recordings this month, the limit under your current billing plan.

To upgrade your account, please visit your billing to upgrade to another billing plan.

https://on.cypress.io/dashboard/organizations/{ordId}/billing

@jennifer-shehane
Copy link
Member

@chrisbreiding I've updated the url links above in my error message examples to the directly link to orgs billing that should be used. If the orgId doesn't exist for some reason, should fall back to https://on.cypress.io/set-up-billing

@jennifer-shehane
Copy link
Member

jennifer-shehane commented Sep 17, 2018

Plan does not include parallelization feature (in grace period) 200

Parallelization is not included under your free plan.

Your plan is now in a grace period, which means your tests will still run in parallel until {gracePeriodEnds}. Please upgrade your plan to continue running your tests in parallel in the future.

https://on.cypress.io/dashboard/organizations/{ordId}/billing

Plan does not include parallelization feature 402

Parallelization is not included under your current billing plan.

To run your tests in parallel, please visit your billing and upgrade to another plan with parallelization.

https://on.cypress.io/dashboard/organizations/{ordId}/billing

@brian-mann
Copy link
Member

@jennifer-shehane @chrisbreiding @bahmutov where did we end up on this... it appears there are quite a few things requested to fix in this PR before it can land.

@jennifer-shehane
Copy link
Member

jennifer-shehane commented Nov 1, 2018

I think we may need to add grouping feature error handling

Plan does not include grouping feature (in grace period) 200 PLAN_IN_GRACE_PERIOD_RUN_GROUPING_FEATURE_USED

Grouping is not included under your free plan.

Your plan is now in a grace period, which means your tests will still run with groups until {gracePeriodEnds}. Please upgrade your plan to continue running your tests with groups in the future.

https://on.cypress.io/dashboard/organizations/{ordId}/billing

Plan does not include grouping feature 402 RUN_GROUPING_FEATURE_NOT_AVAILABLE_IN_PLAN

Grouping is not included under your current billing plan.

To run your tests with groups, please visit your billing and upgrade to another plan with parallelization.

https://on.cypress.io/dashboard/organizations/{ordId}/billing

@brian-mann brian-mann merged commit 907bd77 into develop Nov 6, 2018
@chrisbreiding chrisbreiding deleted the issue-1689-over-limit-errors branch December 11, 2018 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants