-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warnings/errors for recording limits #2397
Conversation
- need to make sure error code lines up with api - error message needs work
I like the messages, and there are still 2 |
Yes, I'm not sure what kind of messaging we want around how to increase the limit or whether we want to tell them they can not record. cc/ @brian-mann |
Free plan exceeded limit (in grace period) 200
Free plan exceeded limit 402
Paid plan exceeded limit
|
@chrisbreiding I've updated the url links above in my error message examples to the directly link to orgs billing that should be used. If the orgId doesn't exist for some reason, should fall back to |
Plan does not include parallelization feature (in grace period) 200
Plan does not include parallelization feature 402
|
@jennifer-shehane @chrisbreiding @bahmutov where did we end up on this... it appears there are quite a few things requested to fix in this PR before it can land. |
I think we may need to add grouping feature error handling Plan does not include grouping feature (in grace period) 200
Plan does not include grouping feature 402
|
Closes #1689
The error/warning messages need work and the properties used (daysLeft, limit, etc) need to be aligned with the API once implemented.