Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Froala (WYSIWYG HTML Editor) does not read correctly the virtual keyboard input of Cypress #2096

Closed
e7d opened this issue Jul 4, 2018 · 2 comments · Fixed by #2016
Closed
Assignees
Milestone

Comments

@e7d
Copy link

e7d commented Jul 4, 2018

Current behavior:

The virtual keyboard inputs does not work as expected, especially regarding the meta keys. In the specific case of the ENTER key, the expected line feed doesn't seem to be outputted at all on the Froala editor.
Considering the example stringto be outputted by Cypress in the Froala Editor:

Hello{enter}{enter}{enter}world!

Then the result is actually looking like this:
image

Desired behavior:

When running my end-to-end tests with Cypress on a webpage including a Froala editor, the virtual keyboard inputs should behave as a real.
If the test run by Cypress inputs the following string (same as above) in the Froala editor:

Hello{enter}{enter}{enter}world!

I intend to get 3 line feeds between Hello and world!, producing an inner HTML looking like this:

<p>Hello</p><p><br></p><p><br></p><p>world!</p>

The result should look like following in an actual webpage:
image

Steps to reproduce:

I made a simple GitHub repository that repoduces the problem live.

  1. Clone https://github.com/jack-in-the-box/froala-vs-cypress.git with git
  2. At the root of the produced folder, run npm run gui (this installs the dependencies of Cypress and then, runs its GUI)
  3. Click on the froala.spec.js link:
    image
  4. Cypress runs the test on Chrome 67 for you
  5. The actual routine of the test can be seen on the file cypress/integration/froala.spec.js

Versions

Latest version of Cypress, on Ubuntu, running Google Chrome 67

@e7d e7d changed the title Froala (WYSIWYG HTML Editor) does not read correctly the virtual keyboard input of Cypress (end-to-end testing framework) Froala (WYSIWYG HTML Editor) does not read correctly the virtual keyboard input of Cypress Jul 4, 2018
@e7d
Copy link
Author

e7d commented Jul 4, 2018

As I don't know which of Froala and Cypress leads to this results, i opened a corresponding ticket here:
froala/wysiwyg-editor#2939

@kuceb
Copy link
Contributor

kuceb commented Jul 5, 2018

Hi @e7d This issue will be fixed in an upcoming patch release, along with many other issues in the #1241 epic for cy.type() improvements!

@kuceb kuceb self-assigned this Jul 5, 2018
@kuceb kuceb added the type: bug label Jul 5, 2018
@kuceb kuceb added this to the 3.0.3 milestone Jul 5, 2018
brian-mann pushed a commit that referenced this issue Jul 23, 2018
this grew to a large PR fixing many cy.type issues.

fix #365
fix #420
fix #586 
fix #593 
fix #596 
fix #610 
fix #651
fix #940
fix #1002 
fix #1108
fix #1171
fix #1209 
fix #1234 
fix #1366
fix #1381 
fix #1684 
fix #1686
fix #1926 
fix #2056
fix #2096 
fix #2110 
fix #2173
fix #2187
@jennifer-shehane jennifer-shehane added stage: pending release and removed stage: needs review The PR code is done & tested, needs review stage: needs investigating Someone from Cypress needs to look at this stage: in progress labels Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants