Chaining is broken when reusing same options object in .type() command

[bahmutov]

Here is a good one (Cypress 0.18.4)

This works

const dontLog = {log: false}
  cy
    .visit(url)
    .get('[name=email]', dontLog).clear().type(email, dontLog)
    .get('[name=password]', dontLog).clear().type(password, {log: false})
    .get('button', {log: false}).click({log: false})

This does not work (enters the password in the email field instead

const dontLog = {log: false}
  cy
    .visit(url)
    .get('[name=email]', dontLog).clear().type(email, dontLog)
    .get('[name=password]', dontLog).clear().type(password, dontLog)
    .get('button', {log: false}).click({log: false})

The above code is inside custom command Cypress.addParentCommand('login') {...}

I am attaching the video (without clicking submit so it stops and shows the problem)

[bahmutov]

If I try freezing the options object, it throws an error "TypeError: Cannot read property 'is' of undefined".

const dontLog = Object.freeze({log: false})
  cy
    .visit(url)
    .get('[name=email]', dontLog).clear().type(email, dontLog)
    .get('[name=password]', dontLog).clear().type(password, dontLog)

[brian-mann]

Yah we are internally mutating those objects which makes sense why this fails. Probably should not be doing that, should clone them first.

Curious why you can't use cy.request here, instead of using your UI to perform those same actions. I'm guessing you're wrapping this up as a custom command.

[bahmutov]

this is a custom login command, which includes CSRF token. You probably want to use at least Cypress._.clone(options) ;)

[brian-mann]

I see. You can still use cy.request for CSRF tokens.

Here's an example.

https://github.com/cypress-io/cypress-example-recipes#logging-in---csrf-tokens

[bahmutov]

of course, I saw that example yesterday :) But it a lot flakier than going through UI :)
"Flaky" is a wrong word - it is a lot more tied to implementation.

[brian-mann]

How's it flakier? It should be much less flakier and much faster.