-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
the experimentalSessionAndOrigin feature should not be available in component testing #21573
Milestone
Comments
AtofStryker
added a commit
that referenced
this issue
May 20, 2022
5 tasks
cypress-bot
bot
added
the
stage: needs review
The PR code is done & tested, needs review
label
May 20, 2022
These bulletpoints should be addressed in #21588 |
5 tasks
cypress-bot
bot
added
stage: internal
and removed
stage: needs review
The PR code is done & tested, needs review
labels
May 23, 2022
AtofStryker
added a commit
that referenced
this issue
May 23, 2022
#21588) * fix: do not allow experimentalSessionAndOrigin to be available in CT per #21573 * remove experimentalSessionAndOrigin config as it is read only * move runner session tests under own system test project to turn on experimentalSessionAndOrigin flag * refactor session ui runner tests to point to runner-session-e2e-specs folder * fix cypress_spec.js to account for experimentalSessionAndOrigin options * remove experimentalSessionAndOrigin from env args
The code for this is done in cypress-io/cypress#21588, but has yet to be released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What would you like?
experimentalSessionAndOrigin
should be an e2e-only configuration option. Later we must evaluate if using session in CT would be valuable as well was what test isolation in CT looks like, if it is available at all.There also needs to be an update to the migration algorithm to prevent adding this config to CT?
The change may be similar to this:
https://github.com/cypress-io/cypress/blob/10.0-release/packages/data-context/src/sources/migration/codegen.ts#L436-L440
Why is this needed?
cy.session
andcy.origin
are both experimental and need further evaluation on their relevance to Component testing.Other
experimentalSessionAndOrigin
within the E2E object of the configuration file.experimentalSessionAndOrigin
at the global config to move it into the E2E object during 10.0 migration.experimentalSessionAndOrigin
exists within the global config object for the CT config object.experimentalSessionAndOrigin
as an E2E config only property in the unification docs.The text was updated successfully, but these errors were encountered: