fix: do not allow experimentalSessionAndOrigin to be available in CT … #21588
Conversation
|
Thanks for taking the time to open a PR!
|
| @@ -209,7 +209,7 @@ const resolvedOptions: Array<ResolvedConfigOption> = [ | |||
| defaultValue: false, | |||
| validation: validate.isBoolean, | |||
| isExperimental: true, | |||
| canUpdateDuringTestTime: true, | |||
| canUpdateDuringTestTime: false, | |||
There was a problem hiding this comment.
This probably should be in its own commit, but I noticed we had this enabled to be updated during test time, when it should not be able to be updated during test time.
There was a problem hiding this comment.
@AtofStryker is this a breaking change from 9.x?
There was a problem hiding this comment.
@emilyrohrbough I think it's just wrong here. Should be fine in 9.x. My guess is it wasn't caught when merging in with the 10.x-release branch.
There was a problem hiding this comment.
@emilyrohrbough thank you! I did want to point out though that this did cause some issues with the config flag being set through the global config function for some of the session runner cy-in-cy tests. I moved the session.ui tests to point to a new directory with the session tests moved into it with the experimental flag turned on in the config in e214495, 1677ca0, and fd08b57
AtofStryker
requested review from
jennifer-shehane,
estrada9166,
JessicaSachs,
mjhenkes,
mschile,
emilyrohrbough and
chrisbreiding
and removed request for
a team and
jennifer-shehane
|
Looks like I need to update the config of some tests 😅 |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
…pack * develop: test(launchpad): skip failure due to recaptcha on windows, enable more windows jobs (#21620) docs: add "Steps to test" to PR template (#21606) feat: (origin) handle waiting for aliased intercepts (#21579) fix: handle git watch error (#21600) fix: Successfully create new specs files that do not have a known extension (#21593) chore: release 9.7.0 fix: do not allow experimentalSessionAndOrigin to be available in CT … (#21588) chore: sort the frameworks select dropdown in a more logical way (#21553) Trigger Build fix: disable ct testing when run via binary (#21540) chore: Update Chrome (beta) to 102.0.5005.61 (#21556) chore: release @cypress/react-v5.12.5 fix: add support for Next.js v12.1.6 (#21516) chore: release @cypress/schematic-v1.7.0 feat(cypress/schematic): add headed option and other fixes (#21415) chore: release @cypress/vite-dev-server-v2.2.3 fix: handle specs with white space in vite-dev-server (#21386) Empty commit
…per #21573
User facing changelog
Additional details
The goal of this PR is to make
experimentalSessionAndOriginscoped toe2etesting only until we evaluate how session would be used, as well as test isolation, in the CT environment.Updates to the
confighave been added to forbid use of theexperimentalSessionAndOriginflag, as well as added tests to make sureexperimentalSessionAndOriginis migrated to thee2econfig options and not kept at the root level. There is also an added system test to verify error messaging if a user tries to add theexperimentalSessionAndOriginflag under thecomponentconfig.How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?cypress.schema.json?